Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update / CLI Help Text #5

Open
gauntface opened this issue Jan 12, 2017 · 3 comments
Open

Readme update / CLI Help Text #5

gauntface opened this issue Jan 12, 2017 · 3 comments

Comments

@gauntface
Copy link

Just tried playing around with the CLI but with no operation being used this is the output:

$ admiral
(node:5521) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'dependencies' of null
(node:5521) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
@jaridmargolin
Copy link
Contributor

Ahhh interesting. admiral standalone should be enough to run the tests.

I believe this is coming from a downstream lib while trying to "load plugins". I should catch it and give clearer context as to what is happening. Does your project not contain a package.json?

@jaridmargolin
Copy link
Contributor

May actually be interested in submitting an issue to the underlying lib to see why it relies on package.json rather than reading the node_modules directory. Perhaps just speed to avoid all of the I/O?

@jaridmargolin
Copy link
Contributor

Opened discussion over @ jonschlinkert/load-plugins#14 regarding what the behavior should be when a package.json file does not exist in the repo.

Also created an issue over @ admiraljs/pawn#4 to make sure all errors are correctly output.

Thanks for logging and apologies for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants