Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow limiting hook concurrency. #148

Open
wrouesnel opened this issue Jun 28, 2017 · 2 comments
Open

Allow limiting hook concurrency. #148

wrouesnel opened this issue Jun 28, 2017 · 2 comments

Comments

@wrouesnel
Copy link
Contributor

When trigger bash scripts or other functions which have some associated runtime, there are many situations where it's desirable to only allow exactly 1 instance of a hook to be executing at a time (or a limited number).

While this could be accomplished with various locking systems at the hook level, these have the downside that they still lead to spawning new shell processes, which are much more expensive then the goroutines which handle the incoming webhooks.

It would be extremely useful if a max-concurrency flag could be specified for a webhook definition which would cause webhook to queue requests that exceed it

@adnanh
Copy link
Owner

adnanh commented Jun 28, 2017

I'd be more than glad to accept a good PR for this feature! 👍

@adnanh
Copy link
Owner

adnanh commented Sep 14, 2017

Future looks bright for this one :-) Just a little bit more polish and it'll be ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants