-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spec] Valid whitespace characters in feature files? #191
Comments
In my opinion, all whitespace characters should be valid in feature files (even line breaks). This should be valid:
|
Whitespace characters is a long list in Unicode (and potentially open ended with future additions to Unicode), the spec should explicitly list what characters are treated as such instead. |
Since the feature file specification does not allow for non-ASCII characters, I don’t think this is an issue. |
The non-breaking space is U+00A0, which is (barely) outside of ASCII, so based on @frankrolf's statement, its presence outside of comments should throw an error. While we're on the subject, the following are the Unicode Version 10.0 characters that have the White_Space property:
|
Yes, 0x0a is not ASCII, but some font editors apparently do not prevent non-ASCII characters from ending up in feature files. For example, in my case the file was in a UFO generated by glyphsLib from a Glyphs file. The feature file was UTF-8-encoded. Maybe this should be decided together with #165. |
makeotf
apparently allows non-breaking space characters as whitespace in feature files, whilefontTools.feaLib
doesn’t. Is there a list of which whitespace characters are valid somewhere?The text was updated successfully, but these errors were encountered: