Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codepens should be embedded responsively (easier said than done) #73

Open
mvujovic opened this issue Sep 8, 2014 · 1 comment
Open
Labels

Comments

@mvujovic
Copy link
Member

mvujovic commented Sep 8, 2014

The content inside a Codepen can be responsive, but it won't affect the layout of the embedding page. Instead the responsive Codepen content will be clipped. (See the Filters Codepen.)

Unfortunately, there isn't a simple solution here. You have to implement some JavaScript to communicate the iframe's content height back to the embedding page and update it on resize.

It looks like some people have tackled this already:
http://npr.github.io/responsiveiframe/

Maybe Codepen has tackled this somehow (though probably wishful thinking).

We should find the right general solution for all of our Codepens and use it.

@mvujovic mvujovic added the bug label Sep 8, 2014
@mvujovic
Copy link
Member Author

mvujovic commented Sep 8, 2014

@jacobgoldstein @rhauck @lmclister FYI

@lmclister lmclister modified the milestone: After initial launch Sep 11, 2014
@rhauck rhauck added the P2 label Sep 23, 2014
@rhauck rhauck modified the milestone: MAX Release Sep 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants