Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript errors on Product pages if Product can't be found #369

Closed
dhardtke opened this issue Aug 10, 2020 · 1 comment · Fixed by #370
Closed

JavaScript errors on Product pages if Product can't be found #369

dhardtke opened this issue Aug 10, 2020 · 1 comment · Fixed by #370

Comments

@dhardtke
Copy link
Contributor

Expected Behaviour

When opening a product page where the product can't be found, the Product component should not throw.

Actual Behaviour

Screenshot_20200810_125119
When loading the page (e.g. http://localhost:4502/content/venia/us/en/products/product-page.i-do-not-exist.html) a JS error appears in the console.

Reproduce Scenario (including but not limited to)

Open a product detail page where the product can't be found.

Steps to Reproduce

  1. Open http://localhost:4502/content/venia/us/en/products/product-page.i-do-not-exist.html
  2. Notice the error in the console (see the screenshot above)

Platform and Version

AEM 6.5.5 on-premise, CIF Components 1.2.0

Sample Code that illustrates the problem

Logs taken while reproducing problem

@dhardtke dhardtke changed the title JavaScript error on Product pages if Product can't be found JavaScript errors on Product pages if Product can't be found Aug 10, 2020
@herzog31
Copy link
Member

Fixed by #370.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants