Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOC] Write UI Tests and dev components page #1816

Open
gabrielwalt opened this issue Sep 6, 2021 · 2 comments
Open

[TOC] Write UI Tests and dev components page #1816

gabrielwalt opened this issue Sep 6, 2021 · 2 comments
Labels
done enhancement New feature, or improvement to an existing feature.
Milestone
Future

Comments

@gabrielwalt
Copy link
Member

gabrielwalt commented Sep 6, 2021 •
edited by github-jira-sync-bot
Loading

  • Don’t allow authors to configure invalid options in the dialog by validating the options and preventing a start level that is bigger than the stop level.
  • Don’t throw errors on invalid configurations, but rather warnings as errors might be monitored and escalated.
  • Order both the start-level and the end-level drop-downs the same way (ascending, from H1 to H6).
  • Rename the title levels to "H1"-"H6" in the UI and to h1-h6 in the JCR persistence and in the JSON returned by the Sling Models.
  • For titles that have the same text, make their ID unique by appending a number, but don’t append anything to titles that already are unique.
  • Keep up the amazing work, we're almost done!

PR - #2030 
@gabrielwalt gabrielwalt added the enhancement New feature, or improvement to an existing feature. label Sep 6, 2021
@gabrielwalt
Copy link
Member Author

@adobe export issue to Jira project SITES

@github-jira-sync-bot
Copy link
Collaborator

✅ Jira issue SITES-2580 is successfully created for this GitHub issue.

@github-jira-sync-bot github-jira-sync-bot added the in progress Work is underway on implementing this fix or enhancement. label Sep 20, 2021
@github-jira-sync-bot github-jira-sync-bot changed the title Table of Content Component Table of Contents Component Nov 8, 2021
@gabrielwalt gabrielwalt added this to the Future milestone Nov 19, 2021
@github-jira-sync-bot github-jira-sync-bot added to verify issue is resolved, waiting to be tested and verified done and removed in progress Work is underway on implementing this fix or enhancement. to verify issue is resolved, waiting to be tested and verified labels Dec 1, 2021
@github-jira-sync-bot github-jira-sync-bot changed the title Table of Contents Component Table of Contents Component - Definition Dec 3, 2021
@github-jira-sync-bot github-jira-sync-bot changed the title Table of Contents Component - Definition Table of Contents Component - Implementation Dec 3, 2021
@github-jira-sync-bot github-jira-sync-bot changed the title Table of Contents Component - Implementation [TOC] Backend Implementation Dec 15, 2021
@github-jira-sync-bot github-jira-sync-bot changed the title [TOC] Backend Implementation [TOC] Make nested list of TOC Dec 15, 2021
@github-jira-sync-bot github-jira-sync-bot changed the title [TOC] Make nested list of TOC [TOC] Raise RTC to add JSOUP in AEM Dec 15, 2021
@github-jira-sync-bot github-jira-sync-bot changed the title [TOC] Raise RTC to add JSOUP in AEM [TOC] Unit Tests and Integration Tests Dec 15, 2021
@github-jira-sync-bot github-jira-sync-bot changed the title [TOC] Unit Tests and Integration Tests [TOC] Write Unit Tests and Integration Tests Dec 15, 2021
@github-jira-sync-bot github-jira-sync-bot added in progress Work is underway on implementing this fix or enhancement. and removed done labels Jan 18, 2022
@github-jira-sync-bot github-jira-sync-bot added to verify issue is resolved, waiting to be tested and verified done in progress Work is underway on implementing this fix or enhancement. and removed in progress Work is underway on implementing this fix or enhancement. to verify issue is resolved, waiting to be tested and verified done labels Feb 2, 2022
@github-jira-sync-bot github-jira-sync-bot changed the title [TOC] Write Unit Tests and Integration Tests [TOC] Write Unit Tests Feb 22, 2022
@github-jira-sync-bot github-jira-sync-bot added in review in progress Work is underway on implementing this fix or enhancement. and removed in progress Work is underway on implementing this fix or enhancement. in review labels Mar 2, 2022
@github-jira-sync-bot github-jira-sync-bot added to verify issue is resolved, waiting to be tested and verified done and removed in progress Work is underway on implementing this fix or enhancement. to verify issue is resolved, waiting to be tested and verified labels Mar 2, 2022
@github-jira-sync-bot github-jira-sync-bot changed the title [TOC] Write Unit Tests [TOC] Write UI Tests and dev components page Mar 22, 2022
@github-jira-sync-bot github-jira-sync-bot added to verify issue is resolved, waiting to be tested and verified done in progress Work is underway on implementing this fix or enhancement. in review and removed in review to verify issue is resolved, waiting to be tested and verified done in progress Work is underway on implementing this fix or enhancement. labels Mar 22, 2022
@github-jira-sync-bot github-jira-sync-bot added to verify issue is resolved, waiting to be tested and verified done in review and removed in review to verify issue is resolved, waiting to be tested and verified done labels Apr 6, 2022
@github-jira-sync-bot github-jira-sync-bot added to verify issue is resolved, waiting to be tested and verified done and removed in review to verify issue is resolved, waiting to be tested and verified labels Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
done enhancement New feature, or improvement to an existing feature.
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@gabrielwalt @github-jira-sync-bot