Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a JSON schema to describe app.config.yaml and output of the lib #11

Closed
moritzraho opened this issue Dec 15, 2022 · 3 comments
Closed

Use a JSON schema to describe app.config.yaml and output of the lib #11

moritzraho opened this issue Dec 15, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@moritzraho
Copy link
Member

moritzraho commented Dec 15, 2022 •
edited
Loading

The output configuration object is used as input to multiple aio libraries such as aio-lib-runtime and aio-lib-web.
It is also used in standalone environments.

Clearly defining the schema will help us avoid bugs.
@moritzraho moritzraho changed the title Should we add a JSON schema to describe the output of this lib Use a JSON schema to describe app.config.yaml and output of the lib Mar 2, 2023
@moritzraho
Copy link
Member Author

moritzraho commented Mar 2, 2023 •
edited
Loading

This would help with testing too.
And we could provide some autocompletion and validation for app.config.yaml

@moritzraho moritzraho added the enhancement New feature or request label Mar 2, 2023
@sandeep-paliwal sandeep-paliwal mentioned this issue Mar 29, 2023
Merged
9 tasks
@shazron
Copy link
Member

shazron commented May 8, 2023

See adobe/aio-cli-plugin-app#667

@shazron shazron mentioned this issue May 8, 2023
Merged
10 tasks
@shazron shazron added enhancement New feature or request and removed enhancement New feature or request labels May 8, 2023
@aiojbot
Copy link

aiojbot commented May 8, 2023

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2243

@shazron shazron mentioned this issue May 8, 2023
Closed
@moritzraho moritzraho mentioned this issue May 16, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shazron @moritzraho @aiojbot