add support for proxies. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcallsen
approved these changes
Aug 4, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
# [1.2.0](v1.1.1...v1.2.0) (2023-08-04) ### Features * add support for proxies. ([#18](#18)) ([fc93b6c](fc93b6c))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per customer request, they would like to use the CLI but their configuration requires a proxy. This PR adds proxy support to the CLI, and follows the support guidelines described in the aio-cli. In summary, a proxy URL can be defined in an environment variable, and the CLI will pick up the value in provide it to
aem-uploadto allow proxying.Related Issue
Submitted internally.
Motivation and Context
Customer is using the CLI to upload assets as part of an automated job, and requires a way to configure a proxy so that requests to AEM succeed.
How Has This Been Tested?
Added new unit tests, will request some manual testing.
Screenshots (if appropriate):
N/A
Types of changes
Checklist: