Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command chaining, and separators broken #315

Closed
purplecabbage opened this issue Oct 30, 2020 · 3 comments · Fixed by #321
Closed

Command chaining, and separators broken #315

purplecabbage opened this issue Oct 30, 2020 · 3 comments · Fixed by #321
Assignees
Labels
bug Something isn't working

Comments

@purplecabbage
Copy link
Member

purplecabbage commented Oct 30, 2020

The latest release has broken command interpretation.
Previously we used npm run-script to do the command processing for us, but changes to support long running processes also changed it so we are running the scripts ourselves. Our command interpretation only cares about spaces, and treats everything after the first space as an argument.

[[ "a" = "a" ]] && echo ok
echo it was okay > someFile.txt
cat package.json | jq .name

@aiojbot
Copy link
Collaborator

aiojbot commented Nov 2, 2020

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-949

@shazron
Copy link
Member

shazron commented Nov 2, 2020

There is an execa option that treats the whole string as a command: https://www.npmjs.com/package/execa#execacommandcommand-options

Will need to modify to use that and see if that fixes the issue.

@shazron
Copy link
Member

shazron commented Nov 2, 2020

@purplecabbage If we want to use shell specific features (like in your first example in the description with bash stuff) we need to enable the shell option in execa which comes with caveats: https://www.npmjs.com/package/execa#shell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants