Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove devDependency babel-runtime, replace with core-js@^3 #539

Closed
shazron opened this issue Jun 2, 2022 · 1 comment · Fixed by #550
Closed

remove devDependency babel-runtime, replace with core-js@^3 #539

shazron opened this issue Jun 2, 2022 · 1 comment · Fixed by #550
Assignees
Labels
bug Something isn't working

Comments

@shazron
Copy link
Member

shazron commented Jun 2, 2022

Description

Related: adobe/generator-add-web-assets-exc-react#1

babel-runtime includes core-js@2, and is over 5 years old. With the new parcel, which includes babel, it requires core-js@^3.

Error

This old dependency is causing an error during aio app run:

❯ aio app run
   create .vscode/launch.json

No change to package.json was detected. No package manager install will be executed.

To view your local application:
  -> https://localhost:9080
To view your deployed application in the Experience Cloud shell:
  -> https://experience.adobe.com/?devMode=true#/custom-apps/?localDevUrl=https://localhost:9080
press CTRL+C to terminate dev environment
🚨 Build failed.

@parcel/core: Failed to resolve 'core-js/modules/es.symbol.async-iterator.js' from
'/Users/shazron/Documents/git/work/adobe/aio-cli-plugin-app/node_modules/@parcel/transformer-js/lib/JSTransformer.js'

  /Users/shazron/Desktop/tmp/exc-1/src/dx-excshell-1/web-src/src/index.js:1:1
  > 1 | /*
  >   | ^
    2 | * <license header>
    3 | */

Fix

  1. remove devDep babel-runtime
  2. add devDep core-js@^3
@aiojbot
Copy link
Collaborator

aiojbot commented Jun 2, 2022

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-1674

@shazron shazron self-assigned this Jun 2, 2022
@shazron shazron changed the title remove devDep babel-runtime, replace with core-js@^3 remove devDepency babel-runtime, replace with core-js@^3 Jun 2, 2022
@shazron shazron changed the title remove devDepency babel-runtime, replace with core-js@^3 remove devDependency babel-runtime, replace with core-js@^3 Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants