Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app plugin: code links in README point to a .ts file #759

Closed
shazron opened this issue Feb 1, 2024 · 4 comments · Fixed by #760
Closed

app plugin: code links in README point to a .ts file #759

shazron opened this issue Feb 1, 2024 · 4 comments · Fixed by #760
Labels
bug Something isn't working

Comments

@shazron
Copy link
Member

shazron commented Feb 1, 2024

Example:
https://github.com/adobe/aio-cli-plugin-app?tab=readme-ov-file#aio-app-add has See code: to src/commands/app/add/index.ts

Expected:
The code link should point to the actual file, which has a .js extension

@shazron shazron added the bug Something isn't working label Feb 1, 2024
@aiojbot
Copy link
Collaborator

aiojbot commented Feb 1, 2024

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2800

@shazron
Copy link
Member Author

shazron commented Feb 1, 2024

@shazron
Copy link
Member Author

shazron commented Feb 1, 2024

Our eslint config has typescript in it, but I forget why I had to add it for this commit: adobe/eslint-config-aio-lib-config@88c8f96
Removing it from the eslint config, publishing a major, and removing typescript from our plugins (and using the updated eslint config) will fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants