New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #166

Open

moritzraho opened this issue Aug 5, 2022 · 0 comments

Member

moritzraho commented Aug 5, 2022 •

edited

Loading

Remote storage uploadFile should not have a dependency towards appConfig https://github.com/adobe/aio-lib-web/blob/master/lib/remote-storage.js#L110

As we do for config.s3.folder we should pass specific values and not have remote storage depend on the config object https://github.com/adobe/aio-lib-web/blob/master/src/deploy-web.js#L45

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment