Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make work when flex box is involved #51

Closed
mkstix6 opened this issue Mar 10, 2015 · 6 comments
Closed

make work when flex box is involved #51

mkstix6 opened this issue Mar 10, 2015 · 6 comments

Comments

@mkstix6
Copy link

mkstix6 commented Mar 10, 2015

Is anyone else having issues when flex box is also used on the .balance-text element or parents that control it's width?

@redmunds
Copy link
Contributor

I haven't heard anyone report that. Can you provide an example?

@mkstix6
Copy link
Author

mkstix6 commented Mar 10, 2015

K cool. I'll look at making a codepen soon. Could just be something I messed up.

@redmunds
Copy link
Contributor

Closing until I receive more info.

@spinboxnl
Copy link

Hi Redmunds,

This problem occurs when the .balance-text element is a direct child of a flexbox element.

The following code causes the width to be not correct and the code not to be executed. I guess display:inline; and position:static still has max-width of the flexbox. Changing this to block and absolute fixed it, but I didn't test if it breaks anything else.

// temporary settings $this.css({ 'white-space': 'nowrap', 'float': 'none', 'display': 'inline', 'position': 'static' });

I myself fixed this issue by adding a block element as the direct child. Thanks for your work!

@redmunds
Copy link
Contributor

redmunds commented Jul 3, 2016

@spinboxnl Thanks for the detailed followup. This can't be made as a global change -- see discussion in #75. But, I'll keep this case in mind with future changes.

@fregante
Copy link
Contributor

fregante commented Jul 5, 2016

A solution for this one might be using selections to calculate the necessary width, instead of removing the text. This would be a near-total rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants