Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$.balanceTextUpdate() should be $.fn.balanceTextUpdate()? #92

Closed
jab opened this issue Jul 29, 2016 · 5 comments
Closed

$.balanceTextUpdate() should be $.fn.balanceTextUpdate()? #92

jab opened this issue Jul 29, 2016 · 5 comments

Comments

@jab
Copy link

jab commented Jul 29, 2016

The README says to call $.balanceTextUpdate() to manually re-balance all triggered elements, but that causes Uncaught TypeError: $.balanceTextUpdate is not a function(…). Changing this to $.fn.balanceTextUpdate() seems to do the trick.

@redmunds
Copy link
Contributor

@jab Thanks. Fixed.

@jab
Copy link
Author

jab commented Jul 31, 2016

Thanks for fixing, for the other docs improvements, and for balance-text in general, @redmunds. Hope efforts to get this into the CSS spec are going well.

@jab
Copy link
Author

jab commented Jul 31, 2016

By the way, I was seeing balance-text not working in my (Polymer-using) web app when testing in mobile Chrome and Safari on my iPhone (running latest iOS 9.3.3) in many cases until I added a call to $.fn.balanceTextUpdate() in a 'WebComponentsReady' event listener. (This problem did not occur in Chrome or Safari on latest OS X.) Seems worth documenting this so other users are aware of it, and if this is not expected behavior, I'd be happy to file another issue for fixing it.

@redmunds
Copy link
Contributor

@jab Interesting. Yes, please open a new issue for that.

@jab
Copy link
Author

jab commented Jul 31, 2016

Please see #93, which includes a link to a minimal test case. In creating that, I realized the problem actually reproduces on desktop too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants