Use NSWorkspace's method for revealing in finder

Alex Zielenski · Alex Zielenski · commit b40bdcdeb2dd · 2013-03-31T17:12:05.000-03:00
It is more reliable than applescript and works for Path Finder users as well
diff --git a/appshell/appshell_extensions_mac.mm b/appshell/appshell_extensions_mac.mm
@@ -604,11 +604,7 @@ - (void) timeoutTimer:(NSTimer*)timer
 
 int32 ShowFolderInOSWindow(ExtensionString pathname)
 {
-    NSString* scriptString = [NSString stringWithFormat: @"activate application \"Finder\"\n tell application \"Finder\" to open posix file \"%s\"", pathname.c_str()];
-    NSAppleScript* script = [[NSAppleScript alloc] initWithSource: scriptString];
-    NSDictionary* errorDict = nil;
-    [script executeAndReturnError: &errorDict];
-    [script release];
+    [[NSWorkspace sharedWorkspace] activateFileViewerSelectingURLs:[NSArray arrayWithObject: [NSURL fileURLWithPath: pathname.c_str()]]];
     return NO_ERROR;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -604,11 +604,7 @@ - (void) timeoutTimer:(NSTimer*)timer`
`604`	`604`
`605`	`605`	`int32 ShowFolderInOSWindow(ExtensionString pathname)`
`606`	`606`	`{`
`607`		`- NSString* scriptString = [NSString stringWithFormat: @"activate application \"Finder\"\n tell application \"Finder\" to open posix file \"%s\"", pathname.c_str()];`
`608`		`- NSAppleScript* script = [[NSAppleScript alloc] initWithSource: scriptString];`
`609`		`- NSDictionary* errorDict = nil;`
`610`		`- [script executeAndReturnError: &errorDict];`
`611`		`- [script release];`
	`607`	`+ [[NSWorkspace sharedWorkspace] activateFileViewerSelectingURLs:[NSArray arrayWithObject: [NSURL fileURLWithPath: pathname.c_str()]]];`
`612`	`608`	`return NO_ERROR;`
`613`	`609`	`}`
`614`	`610`