Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Help for first pull request #14121

Closed
pelatx opened this issue Feb 18, 2018 · 3 comments
Closed

Help for first pull request #14121

pelatx opened this issue Feb 18, 2018 · 3 comments

Comments

@pelatx
Copy link

pelatx commented Feb 18, 2018

Hi.

I have working properly, in a branch derived from "linux-1547" branch of Brackets-shell, the native menus with checked items in Linux (#13606, #13685).

I have been reading the documentation on how to contribute to Brackets, but I have a question:

After signing the CLA, should I create a branch of Brackets-shell "master" and make the changes there? Or should I create the branch derived from "linux-1547"?

Maybe it's an obvious question, but I'm pretty new at contributing to such large projects.

Thank you.

@petetnt
Copy link
Collaborator

petetnt commented Feb 18, 2018

Hi @pelatx,

first of all, thanks for contributing!

While I am not completely up to speed with the current state of the said branch, master got big linux updates a while back so I think it should be safe to target the PR against the master

@pelatx
Copy link
Author

pelatx commented Feb 18, 2018

Thanks @petetnt.

@petetnt
Copy link
Collaborator

petetnt commented Feb 23, 2018

Closing this as answered, do message back if there's more questions!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants