Crash on code hint trigger #4438
Comments
|
I hit this crash again running a "jump to definition". |
|
@dangoor - do you remember what file you were editing at the time? |
ghost
assigned
|
To me to see if I can repro, possibly in an automated fashion. |
|
I just ran into this while trying to write an extension that would repro the crash :) I had codemirror.js open, but was editing another (small) file. |
|
I wrote a simple extension that tries to pop up code hints in various places in the current file. So far it hasn't reproed the crash, even running on codemirror.js for a few minutes. Next thing to try is simulating typing ".", but that turns out to be a little complicated because CHM actually relies on keypress events. Might be possible to just fake it by calling the provider directly. |
|
FWIW, the extension is at https://github.com/njx/brackets-hint-test. I think that rather than trying to use "." to pop up code hints (which I think might not be that different), it might be more interesting to have it make random edits to the file between each hint to cause Tern to rescan the file. @dangoor, do you know if Tern rescans the file any time an edit is made and code hints are re-requested? |
|
@njx I don't remember on what schedule JSCodeHints sends the file to the tern worker for reparsing. I would think it has to be pretty quick after edits are made and before requesting hints, otherwise you wouldn't see local variables as you're writing a new function. |
|
@eztierney may have some ideas on how to stress Tern. |
|
I tried modifying the extension to edit the file between each code hint invocation, but still didn't have any luck reproducing the crash. (I haven't checked in that version of the extension yet.) I also tried randomizing the delay between the edit and popping up code hints, and making multiple edits in a row (synchronously). I didn't try putting in a slight delay between edits, which would better simulate typing, though. |
|
Assigning back to @dangoor - my testing didn't go anywhere, but it looks like Kevin has a pretty reliable repro case now. |
|
I'm closing this one in favor of #4400 because the information in there actually covers our test case and I think it likely that this is the same crash. |
I was just editing Brackets in Brackets. I typed a
.and brackets-helper died. Here's the crash report:This is on Mac OS 10.8.4, using the Brackets Sprint 27 shell and the latest master of the brackets project.
The text was updated successfully, but these errors were encountered: