[Dialogs] No arrows usable to select dialog option

[marcelgerber]

(This an enhanced version of #5538, as I just found a much bigger bug)

When a multiple-choice dialog (more than one available option) shows up, you can't use the arrow keys to select an option. You can use tab to select an option visually, but when you press enter then the default option will be executed.

Steps to repro:

1. Select any file and edit it (don't save!)
2. Try to close Brackets. The "Do you want to save" dialog shows up
3. Try to select something with the arrow keys or with tab

I tested this with following dialogs:

• To update or remove the marked extensions, you need to quit and restart Brackets
• Do you want to save the changes (single file)
• Do you want to save the changes (multiple files)

I think this is a big restriction to the aim to get Brackets working with keyboard-only.

Env: Windows 8
Brackets development build (master b5eccf8) & Brackets Sprint 32 (official release)

[WebsiteDeveloper]

@SAplayer i will look into this.

[njx]

@SAplayer - are you sure that arrow keys are standard for navigating buttons on Windows? My understanding was that it's not--only tab and shift-tab are standard.

Regarding Enter accessing the default button, I need to double-check, but my understanding is that it is actually always supposed to access the default button on both Windows and Mac; the only difference is that on Windows, the default button changes if you tab into the button group that contains the OK/Cancel buttons. We need to do some research on the standard system behavior before diving into implementing this.

Marking low priority to @RaymondLim.

[marcelgerber]

Yep, on Windows 8.1 (MsgBox) the arrow keys set focus to a button. And enter executes the action of this button.

Tab does the same, Shift+Tab the same reverted, Alt+F4 closes a dialog.

[marcelgerber]

@lkcampbell I don't know anymore how this was planned, but currently the selected button is only clicked by pressing space, not by pressing Enter. Was this intended?
Do you want to do the arrow handling or should I try?

[lkcampbell]

@SAplayer, I don't know anything about this issue. Did you direct your comment to the wrong person?

[marcelgerber]

Oh, sorry, I meant @WebsiteDeveloper.

[marcelgerber]

Fixed in #7493.
See #7493 (comment) for more platform details.
Closing.