You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Various parts of our UI code assume only one ModalBar instance can be open at a time (e.g. using selectors like ".modal-bar .foo" to find pieces of UI). However, Nothing globally tracks ModalBar instances; they only show/hide because of blur events, and often only the ModalBar clients even keep track of those events. They also may animate closed or close on a hack timeout (ahem, QuickOpen) -- which means two ModalBars can briefly be open at the same time. This breaks those assumptions.
I'd like to do a cleanup at some point where we (a) eliminate the QuickOpen hacks, (b) use autoClose in more cases, and (c) let ModalBar keep track of its own instances so it can close the previous instance synchronously before opening a new one. This is a placeholder bug for those changes.
The text was updated successfully, but these errors were encountered:
Marking medium priority. @peterflynn - I think there are existing known UI bugs that are caused by this - at some point would you mind linking them to this bug (or if they're not already filed, mention the steps here)?
Result: Quick Open bar closes but the other search bar does not open. Works fine in the reverse direction though.
But to prevent a similar bug when switching between Find/Replace <-> Find in Files, we had to put some fairly hacky code in this sprint -- which would be nice to eliminate.
Various parts of our UI code assume only one ModalBar instance can be open at a time (e.g. using selectors like
".modal-bar .foo"
to find pieces of UI). However, Nothing globally tracks ModalBar instances; they only show/hide because of blur events, and often only the ModalBar clients even keep track of those events. They also may animate closed or close on a hack timeout (ahem, QuickOpen) -- which means two ModalBars can briefly be open at the same time. This breaks those assumptions.I'd like to do a cleanup at some point where we (a) eliminate the QuickOpen hacks, (b) use autoClose in more cases, and (c) let ModalBar keep track of its own instances so it can close the previous instance synchronously before opening a new one. This is a placeholder bug for those changes.
The text was updated successfully, but these errors were encountered: