Hardcoded stoplight window controls no longer a match in OS X 10.10 Yosemite

[kethinov]

The window controls in Brackets appear to be hardcoded and, as such, no longer match the UI style in Yosemite.

Two possible solutions:

1. Don't hardcode them; use native Window frame instead.
2. Update the manually bundled graphics and use OS version number sniffing to detect which graphic set to use.

For reference, here's the new stoplight visual style:

And here's how Brackets looks:

The new style is flat. The old style is pseudo 3d and glossy.

[kethinov]

The fullscreen button on the top right should also be removed.

In OS X 10.10 Yosemite, the new standard behavior for the green button serves two purposes:

1. By default it full screens.
2. When holding the alt key and clicking the green button it will do the former default functionality of zooming.

[pthiess]

@bchintx - medium priority (once Yosemite is going to be out)

[smockle]

I created a set of Yosemite-style window management icons: https://dl.dropboxusercontent.com/u/45326422/buttons.zip. If I have time this week, I'll fork and PR the brackets-shell repo.

Feel free to use them without any limitation. You can try them out by overwriting the current icons in /Applications/Brackets.app/Contents/Resources/.

[peterflynn]

Reviewed - reducing to Low. We'd like this for 1.0 but if it falls off the end it's ok to punt.

[larz0]

FYI Yosemite is scheduled to launch in late October.

[juliusrickert]

Once you put Brackets to full screen to have to reopen it to bring it back to windowed state cause there are no buttons in full screen mode

and there is no menu item for it, too...

[JeffryBooher]

This is fixed in the latest build.

[JeffryBooher]

Sending to the board for more testing. @kethinov if you can build the shell let us know what you think!

[kethinov]

Are there any nightlies I can grab real quick?

[kethinov]

I just did a build from master and don't see the fix. Is there a particular branch I should be looking at?

[ingorichter]

Can you run grunt clean build to be sure that everything gets rebuild? I have build from master 10 mins ago and it looks fine to me.

[JeffryBooher]

@kethinov you're building the shell on Mac OSX using XCode, right?

[peterflynn]

@kethinov Build instructions here btw: https://github.com/adobe/brackets-shell/wiki/Building-Brackets-Shell

[kethinov]

Here's the build process I went through.

brackets-shell> git branch
* master

grunt clean build
Running "clean:downloads" (clean) task
Cleaning "downloads"...OK

Running "clean:installer-mac" (clean) task

Running "clean:installer-win" (clean) task

Running "clean:installer-linux" (clean) task

Running "clean:staging-mac" (clean) task

Running "clean:staging-win" (clean) task

Running "clean:staging-linux" (clean) task

Running "clean:www" (clean) task

Running "build" task

Running "build-mac" task

Done, without errors.

Then I doubled clicked appshell.xcodeproj

It opened in my copy of Xcode 6.1.

Screenshot:

Then I did a build. Build succeeded. After the build succeeded it opened the app, which popped up this:

I picked index.html from a fresh clone of the brackets repo.

And now it just hangs looking like this:

[ingorichter]

@kethinov after you ran grunt build, are you able to run open xdcodebuild/Release/Brackets.app? Does it look the same? Usually you don't need to open XCode to build the brackets shell.

[kethinov]

Just tried that. The app runs now (no longer hangs with a blank gray screen) but I still see the old window controls.

This is on the master branch of brackets-shell, loading an index.html from the master branch of the brackets repo. Both cloned yesterday.

[ingorichter]

Can you do me a favor and tell me what you see when you run defaults read /System/Library/CoreServices/SystemVersion.plist ProductVersion?

[ingorichter]

I can give you a build that our build machine has created. Just to double check.

[kethinov]

defaults read /System/Library/CoreServices/SystemVersion.plist ProductVersion
10.10

[ingorichter]

Okay, that the same info that I can see.

[JeffryBooher]

hey @ingorichter i don't think this has been merged into master yet :)

[ingorichter]

what?

[ingorichter]

It's this one adobe/brackets-shell#478 and that got merged.

[JeffryBooher]

@kethinov it looks like the commits got lost. We're working to figure out what happened.

[ingorichter]

@kethinov we fixed some issues with our repo and if you do a git pull and rebuild, it should have fixed your issues.

[kethinov]

Yes, I see the changes now in my local build.

[kethinov]

👍

[ingorichter]

Hooray! Thanks for your patience. I'm going to close this issue.

[andrewsosa]

Hi! Straight to the point - the year is 2015, and I still have the old headlights issue in Brackets 1.4. On top of that, I also still have the fullscreen button in the upper right corner.

I am currently on OS 10.11 El Capitan, and I'm running build 1.4.0-16380 (release 273804e).

I've tried looking for support in other places, but this is basically the only place I could find the issue being talked about.

[abose]

1.5 to be released this week will fix this along with several improvements for el cap.
This bug got reintroduced in 1.4 due to an if condition gone wrong.