Working set item remains blue when selection highlight moves to folder

[peterflynn]

This might be UTR with the new project tree, but I'm not sure if there are other cases of the same bug too -- seems like the should fix it such that the text color & the selection highlight are always in lockstep.

1. Select something in the working set
2. Click a folder in the file tree

Result: working set item's text is still colored blue, although selection highlight has moved to the project tree

Expected: item only has blue-colored text when it has the selection highlight

[JeffryBooher]

@peterflynn are you seeing this in master? It should only be blue in the jeff/wsv-fixes branch.

[peterflynn]

@JeffryBooher Yes, I'm on master with no local diffs. There's a rule .open-files-container li.selected a, .open-files-container li.selected .extension defined in brackets.less that adds the blue color. So maybe there's some redundant work in that other branch?

[peterflynn]

Oh, looks like this was injected by @larz0 in PR #9127 -- that's where that code was added. And the bug is probably precisely because the selector doesn't depend on .active... If I do a split view, both panes show the blue text too.

[peterflynn]

Assigning @JeffryBooher since it sounds like you'll be able to clean this up when you make a PR for jeff/wsv-fixes

[JeffryBooher]

@peterflynn there was already a selector for this but his was overriding it and it was using a variable for the color whereas the change that @larz0 made wasn't.

Also this needed a little extra love because the active class remained on a working set if the file selector was in the project tree so that is fixed as well.

[redmunds]

I think that was intentional. @larz0 ?

[dangoor]

FYI I noticed this with the new file tree as well (this problem is unrelated)

[JeffryBooher]

that's fine if it was intentional. we should be using a variable for the color property not a CSS RGB HEX value and if we need to remove the .working-set-list-container.active rule since it no longer applles.

[marcelgerber]

I actually like that behaviour, as it actually always shows you which file is currently opened (in each pane).

[JeffryBooher]

@marcelgerber I was thinking the same thing.

[larz0]

@redmunds yep it's intentional.

[redmunds]

@pflynn You said in today's standup that you are not ok with this change. Please state your case so we can resolve this. @JeffryBooher is willing to fix it, if necessary, in #9134, but we need a resolution.

cc @larz0

[peterflynn]

@larz0 After considering this some more, I think this behavior is ok. It still has some slightly odd cases, mostly because the tree doesn't do highlighting quite the same way. But on balance it seems solid enough -- so I'm ok with the behavior that's currently on master.

[larz0]

@peterflynn ok good to know 👍

[JeffryBooher]

I'll fix the pr and close the issue

[JeffryBooher]

closing as not an issue