Extension Manager throws TypeError on selecting tab

[yaddran]

Mac OS X 10.9.5

Release 0.44 experimental build 0.44.0-14876 (release 6d2d33d)
build timestamp: Fri Oct 03 2014 15:05:19 GMT-0700

console log:

Uncaught TypeError: Cannot set property 'scrollPos' of undefined /extensibility/ExtensionManagerDialog.js:310
setActiveTab /extensibility/ExtensionManagerDialog.js:310
(anonymous function) /extensibility/ExtensionManagerDialog.js:319
o.event.dispatch thirdparty.min.js:560
r.handle thirdparty.min.js:560

The code in question:

function setActiveTab($tab) {
    models[_activeTabIndex].scrollPos = $(".modal-body", $dlg).scrollTop(); //line 310
    $tab.tab("show");
    $(".modal-body", $dlg).scrollTop(models[_activeTabIndex].scrollPos || 0);
    $searchClear.click();
}

How to reproduce:

1. Debug -> Show Developer Tools
2. File -> Extension Manager
3. As soon as you see the dialog click on "Installed". You have more time to produce the error if you do this after fresh start of the Brackets but it is always there.

[le717]

Can you empty out the user extensions folder (rename it or something) and see if you can reproduce this? Also, are you running Windows, Mac, etc? I cannot reproduce this myself, also running 0.44.

[marcelgerber]

That's a known issue, filed under #5852

[yaddran]

I am on Mac OS X 10.9.5. And clearing the user extensions does not have any influence.

I am not 100% sure about #5852 but looks connected. In my case the extensions are shown anyway and the dialog does not freeze.... but that aside....

I did some debugging and I've traced the problem to the _activeTabIndex, it is undefined at the moment of the click. So IMHO, a simple check if it is undefined and return if it is should do the job (init is still not done). Or maybe setting an initial value...

btw. should I copy this to 5852?

[marcelgerber]

This is now hopefully fixed on master.

[peterflynn]

Closing as fixed

[busykai]

@peterflynn seems like you forgot to close.

[peterflynn]

Good catch!