Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

ESLint: enable strict rule #12718

Merged
merged 2 commits into from
Aug 25, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
{
"env": {
"node": true
},
"rules": {
"no-bitwise": 0,
"curly": 2,
Expand All @@ -25,7 +22,7 @@
"no-control-regex": 2,
"no-regex-spaces": 2,
"no-undef": 2,
"strict": 0,
"strict": 2,
"no-unused-vars": [0, {"vars": "all", "args": "none"}],
"semi": 2,

Expand Down Expand Up @@ -59,6 +56,7 @@
"$": false,

"window": false,
"console": false,
"setTimeout": false,
"clearTimeout": false,

Expand Down
4 changes: 2 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
*
*/

/*eslint-env node */
/*jslint node: true */

module.exports = function (grunt) {
'use strict';

module.exports = function (grunt) {
// load dependencies
require('load-grunt-tasks')(grunt, {
pattern: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@
*
*/

/*eslint-env node */
/*jslint node: true */

(function () {
"use strict";

var open = require("opn");
Expand Down Expand Up @@ -69,5 +68,3 @@
}

exports.init = init;

}());
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@
*
*/

/*eslint-env node */
/*jslint node: true */

(function () {
"use strict";

var WebSocketServer = require("ws").Server,
Expand Down Expand Up @@ -243,5 +242,3 @@
}

exports.init = init;

}());
1 change: 1 addition & 0 deletions src/extensibility/node/ExtensionManagerDomain.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*
*/

/*eslint-env node */
/*jslint node: true */

"use strict";
Expand Down
1 change: 1 addition & 0 deletions src/extensibility/node/package-validator.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*
*/

/*eslint-env node */
/*jslint node: true, regexp: true */

"use strict";
Expand Down
1 change: 1 addition & 0 deletions src/extensibility/node/spec/Installation.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*
*/

/*eslint-env node */
/*jslint node: true */
/*global expect, describe, it, beforeEach, afterEach */

Expand Down
1 change: 1 addition & 0 deletions src/extensibility/node/spec/Validation.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*
*/

/*eslint-env node */
/*jslint node: true */
/*global expect, describe, it, afterEach */

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@
*
*/

/*eslint-env node */
/*jslint node: true */

(function () {
"use strict";

var http = require("http"),
Expand Down Expand Up @@ -476,5 +475,3 @@
}

exports.init = init;

}());
1 change: 1 addition & 0 deletions src/filesystem/impls/appshell/node/CSharpWatcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
* https://github.com/Microsoft/vscode/blob/314e122b16c5c1ca0288c8006e9c9c3039a51cd7/src/vs/workbench/services/files/node/watcher/win32/csharpWatcherService.ts
*/

/*eslint-env node */
/*jslint node: true */

"use strict";
Expand Down
1 change: 1 addition & 0 deletions src/filesystem/impls/appshell/node/ChokidarWatcher.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*
*/

/*eslint-env node */
/*jslint node: true */

"use strict";
Expand Down
1 change: 1 addition & 0 deletions src/filesystem/impls/appshell/node/FileWatcherDomain.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*
*/

/*eslint-env node */
/*jslint node: true */

"use strict";
Expand Down
1 change: 1 addition & 0 deletions src/filesystem/impls/appshell/node/FileWatcherManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*
*/

/*eslint-env node */
/*jslint node: true */

"use strict";
Expand Down
5 changes: 1 addition & 4 deletions src/search/node/FindInFilesDomain.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,9 @@
*
*/

/*eslint-env node */
/*jslint node: true */
/*global setImmediate */

(function () {
"use strict";

var fs = require("fs"),
Expand Down Expand Up @@ -684,5 +683,3 @@
}

exports.init = init;

}());
4 changes: 2 additions & 2 deletions tasks/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
*
*/

/*eslint-env node */
/*jslint node: true, regexp: true */

module.exports = function (grunt) {
"use strict";

module.exports = function (grunt) {
var child_process = require("child_process"),
http = require("http"),
https = require("https"),
Expand Down
4 changes: 2 additions & 2 deletions tasks/lib/common.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
*
*/

/*eslint-env node */
/*jslint node: true */

module.exports = function (grunt) {
"use strict";

module.exports = function (grunt) {
var common = {},
path = require("path"),
_platform;
Expand Down
4 changes: 2 additions & 2 deletions tasks/npm-install.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
*
*/

/*eslint-env node */
/*jslint node: true */

module.exports = function (grunt) {
"use strict";

module.exports = function (grunt) {
var common = require("./lib/common")(grunt),
build = require("./build")(grunt);

Expand Down
4 changes: 2 additions & 2 deletions tasks/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
*
*/

/*eslint-env node */
/*jslint node: true */

module.exports = function (grunt) {
"use strict";

module.exports = function (grunt) {
var common = require("./lib/common")(grunt),
child_process = require("child_process"),
q = require("q"),
Expand Down
4 changes: 2 additions & 2 deletions tasks/update-release-number.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
*
*/

/*eslint-env node */
/*jslint node: true */

module.exports = function (grunt) {
"use strict";

module.exports = function (grunt) {
var common = require("./lib/common")(grunt),
semver = require("semver");

Expand Down
4 changes: 2 additions & 2 deletions tasks/write-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
*
*/

/*eslint-env node */
/*jslint node: true */

module.exports = function (grunt) {
"use strict";

module.exports = function (grunt) {
var common = require("./lib/common")(grunt),
build = require("./build")(grunt);

Expand Down
1 change: 1 addition & 0 deletions test/node/TestingDomain.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*
*/

/*eslint-env node */
/*jslint node: true */

"use strict";
Expand Down