Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert to ESM so we can use yeoman-generator@v7 and greater #244

Open
shazron opened this issue Jan 18, 2024 · 1 comment
Open

convert to ESM so we can use yeoman-generator@v7 and greater #244

shazron opened this issue Jan 18, 2024 · 1 comment
Labels
breaking-change bug Something isn't working

Comments

@shazron
Copy link
Member

shazron commented Jan 18, 2024

We are already dynamically importing yeoman-test via #241 .
This will be a major version upgrade.

Any users of this lib (which will be made into an ESM) must:

  • not use any explicit paths from the main export (unless we explicitly provide this path)
  • dynamically import this lib, if used from commonjs
@shazron shazron added bug Something isn't working breaking-change labels Jan 18, 2024
@aiojbot
Copy link
Collaborator

aiojbot commented Jan 18, 2024

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shazron @aiojbot