Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should keep styled spans #130

Closed
synox opened this issue Apr 11, 2023 · 1 comment · Fixed by #131
Closed

Should keep styled spans #130

synox opened this issue Apr 11, 2023 · 1 comment · Fixed by #131
Labels
bug Something isn't working released

Comments

@synox
Copy link
Collaborator

synox commented Apr 11, 2023

Description
When importing https://www.volvotrucks.us/privacy-policy/ the underlined spans are removed before they can be processed by the importer.

To Reproduce
Steps to reproduce the behavior:

  1. Import https://www.volvotrucks.us/privacy-policy/
  2. Set breakpoint in the first line of the transform function.
  3. Observe that the span styles are missing.

Expected behavior
Span for styles should be preserved.

Additional context
@synox synox added the bug Something isn't working label Apr 11, 2023
@synox synox mentioned this issue Apr 11, 2023
Merged
2 tasks
@github-actions
Copy link

github-actions bot commented May 4, 2023

🎉 This issue has been resolved in version 2.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@synox synox mentioned this issue Aug 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 130: preserve span with style synox/helix-importer
1 participant
@synox