Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tokencache: respect last-modified of s3 cache before updating #969

Open
tripodsan opened this issue Jul 11, 2024 · 0 comments
Open

tokencache: respect last-modified of s3 cache before updating #969

tripodsan opened this issue Jul 11, 2024 · 0 comments
Assignees

Comments

@tripodsan
Copy link
Contributor

tripodsan commented Jul 11, 2024

Current situation:

  • at time T1, instance A loads the S3 token
  • at time T2, instance B loads the S3 token
  • instance B refreshes the token, stores it back to S3
  • later, instance A also refreshes the token, and writes it back as well, thereby overwriting a perfectly valid token stored by instance B

Instead, instance A should check that the Last-Modified value of the stored token is still the one it has seen when loading in T1. At least, it should internally store the new Last-Modified value, to compare it again when the next refresh happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants