Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS bundling change in February 23, 2023 release #4118

Closed
tchak opened this issue Feb 24, 2023 · 4 comments
Closed

CSS bundling change in February 23, 2023 release #4118

tchak opened this issue Feb 24, 2023 · 4 comments

Comments

@tchak
Copy link

tchak commented Feb 24, 2023

🐛 Bug Report

Something changed in the February 23, 2023 release regarding CSS bundling. I am using react-spectrum with the new CSS bundling support in remix. It was working OK until the new release. Remix compiler is not picking up any spectrum CSS anymore. It is possible that the fix is needed on Remix side but could you point me out to what changed and if you consider it a desired change or a bug?

"@adobe/react-spectrum": "^3.24.1" upgraded to "@adobe/react-spectrum": "^3.25.0"
"@remix-run/css-bundle": "^1.13.0"

@devongovett
Copy link
Member

Oh I think they are missing the .mjs extension in here:

https://github.com/remix-run/remix/blob/f5236c1d880da51d70a8ac24a0922d2e5ded7416/packages/remix-dev/compiler/plugins/cssSideEffectImportsPlugin.ts#L24-L25

@tchak
Copy link
Author

tchak commented Feb 24, 2023

Thanks ! I opened an issue in remix remix-run/remix#5562

@devongovett
Copy link
Member

Thanks I made a PR: remix-run/remix#5564

@devongovett
Copy link
Member

PR has been merged upstream, so I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants