Skip to content

Commit 0a7e4f9

Browse files
committed
chore: apply code review feedback
1 parent cb31306 commit 0a7e4f9

File tree

5 files changed

+53
-52
lines changed

5 files changed

+53
-52
lines changed

migration-roadmap/avatar.md

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -8,25 +8,25 @@
88
<summary>CSS selectors</summary>
99

1010
- `.spectrum-Avatar`
11+
- `.spectrum-Avatar-image`
12+
- `.spectrum-Avatar-link`
13+
- `.spectrum-Avatar--size50`
14+
- `.spectrum-Avatar--size75`
1115
- `.spectrum-Avatar--size100`
12-
- `.spectrum-Avatar--size1000`
13-
- `.spectrum-Avatar--size1100`
14-
- `.spectrum-Avatar--size1200`
15-
- `.spectrum-Avatar--size1300`
16-
- `.spectrum-Avatar--size1400`
17-
- `.spectrum-Avatar--size1500`
1816
- `.spectrum-Avatar--size200`
1917
- `.spectrum-Avatar--size300`
2018
- `.spectrum-Avatar--size400`
21-
- `.spectrum-Avatar--size50`
2219
- `.spectrum-Avatar--size500`
2320
- `.spectrum-Avatar--size600`
2421
- `.spectrum-Avatar--size700`
25-
- `.spectrum-Avatar--size75`
2622
- `.spectrum-Avatar--size800`
2723
- `.spectrum-Avatar--size900`
28-
- `.spectrum-Avatar-image`
29-
- `.spectrum-Avatar-link`
24+
- `.spectrum-Avatar--size1000`
25+
- `.spectrum-Avatar--size1100`
26+
- `.spectrum-Avatar--size1200`
27+
- `.spectrum-Avatar--size1300`
28+
- `.spectrum-Avatar--size1400`
29+
- `.spectrum-Avatar--size1500`
3030
- `.spectrum-Avatar.is-disabled`
3131
- `.spectrum-Avatar.is-focused:not(.is-disabled):after`
3232
- `.spectrum-Avatar:not(.is-disabled) .spectrum-Avatar-link:focus-visible:after`
@@ -78,7 +78,7 @@ None found for this component.
7878
### DOM Structure changes
7979

8080
<details>
81-
<summary>Spectrum Web Components:</summary>
81+
<summary>Spectrum Web Components</summary>
8282

8383
```html
8484
<!-- With link -->
@@ -93,7 +93,7 @@ None found for this component.
9393
</details>
9494

9595
<details>
96-
<summary>Legacy (CSS main branch):</summary>
96+
<summary>Legacy (CSS main branch)</summary>
9797

9898
```html
9999
<!-- With link -->
@@ -122,7 +122,7 @@ None found for this component.
122122
</details>
123123

124124
<details>
125-
<summary>Spectrum 2 (CSS spectrum-two branch):</summary>
125+
<summary>Spectrum 2 (CSS spectrum-two branch)</summary>
126126

127127
```html
128128
<!-- With link -->
@@ -187,13 +187,13 @@ No significant structural changes.
187187

188188
### CSS => SWC implementation gaps
189189

190-
**CSS Features Missing from Web Component:**
190+
**CSS features missing from Web Component:**
191191

192192
- Disabled state support (`.spectrum-Avatar.is-disabled`)
193193
- Focus state support (`.spectrum-Avatar.is-focused`)
194194
- Larger size variants (800, 900, 1000, 1100, 1200, 1300, 1400, 1500)
195195

196-
**Web Component Features Missing from CSS:**
196+
**Web Component features missing from CSS:**
197197
None found for this component.
198198

199199
### CSS Spectrum 2 changes
@@ -202,6 +202,6 @@ No significant structural changes between CSS main and spectrum-two branches. Th
202202

203203
## Resources
204204

205-
- [CSS migration]()
206-
- [Spectrum 2 preview]()
207-
- [React]()
205+
- [CSS migration](https://github.com/adobe/spectrum-css/pull/3355)
206+
- [Spectrum 2 preview](https://spectrumcss.z13.web.core.windows.net/pr-2352/index.html?path=/docs/components-avatar--docs)
207+
- [React](https://react-spectrum.adobe.com/s2/index.html?path=/docs/avatar--docs)

migration-roadmap/opacity-checkerboard.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ None found for this component. This is a utility component used by other compone
5050
### DOM Structure changes
5151

5252
<details>
53-
<summary>Spectrum Web Components:</summary>
53+
<summary>Spectrum Web Components</summary>
5454

5555
```html
5656
<!-- Used as a utility class in other components -->
@@ -62,7 +62,7 @@ None found for this component. This is a utility component used by other compone
6262
</details>
6363

6464
<details>
65-
<summary>Legacy (CSS main branch):</summary>
65+
<summary>Legacy (CSS main branch)</summary>
6666

6767
```html
6868
<div
@@ -78,7 +78,7 @@ None found for this component. This is a utility component used by other compone
7878
</details>
7979

8080
<details>
81-
<summary>Spectrum 2 (CSS spectrum-two branch):</summary>
81+
<summary>Spectrum 2 (CSS spectrum-two branch)</summary>
8282

8383
```html
8484
<div
@@ -115,10 +115,10 @@ No significant structural changes.
115115

116116
### CSS => SWC implementation gaps
117117

118-
**CSS Features Missing from Web Component:**
118+
**CSS features missing from Web Component:**
119119
None found for this component. The opacity checkerboard is implemented as a utility class in the Web Components.
120120

121-
**Web Component Features Missing from CSS:**
121+
**Web Component features missing from CSS:**
122122
None found for this component.
123123

124124
### CSS Spectrum 2 changes
@@ -131,6 +131,6 @@ The opacity checkerboard is a utility component that provides a checkerboard pat
131131

132132
## Resources
133133

134-
- [CSS migration]()
135-
- [Spectrum 2 preview]()
136-
- [React]()
134+
- [CSS migration](https://github.com/adobe/spectrum-css/pull/3394)
135+
- [Spectrum 2 preview](https://spectrumcss.z13.web.core.windows.net/pr-2352/index.html?path=/docs/components-opacity-checkerboard--docs)
136+
- [React](https://react-spectrum.adobe.com/s2/index.html?path=/docs/colorslider--docs) (not a standalone component, but styles are used by the color slider)

migration-roadmap/swatch-group.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
### DOM Structure changes
5656

5757
<details>
58-
<summary>Spectrum Web Components:</summary>
58+
<summary>Spectrum Web Components</summary>
5959

6060
```html
6161
<slot @change="[handleChange]" @slotchange="[manageChange]">
@@ -66,7 +66,7 @@
6666
</details>
6767

6868
<details>
69-
<summary>Legacy (CSS main branch):</summary>
69+
<summary>Legacy (CSS main branch)</summary>
7070

7171
```html
7272
<div
@@ -81,7 +81,7 @@
8181
</details>
8282

8383
<details>
84-
<summary>Spectrum 2 (CSS spectrum-two branch):</summary>
84+
<summary>Spectrum 2 (CSS spectrum-two branch)</summary>
8585

8686
```html
8787
<div
@@ -120,10 +120,10 @@ No significant structural changes.
120120

121121
### CSS => SWC implementation gaps
122122

123-
**CSS Features Missing from Web Component:**
123+
**CSS features missing from Web Component:**
124124
None found for this component.
125125

126-
**Web Component Features Missing from CSS:**
126+
**Web Component features missing from CSS:**
127127

128128
- Border attribute support
129129
- Rounding attribute support
@@ -138,6 +138,6 @@ No significant structural changes between CSS main and spectrum-two branches. Th
138138

139139
## Resources
140140

141-
- [CSS migration]()
142-
- [Spectrum 2 preview]()
143-
- [React]()
141+
- [CSS migration](https://github.com/adobe/spectrum-css/pull/3677)
142+
- [Spectrum 2 preview](https://spectrumcss.z13.web.core.windows.net/pr-2352/index.html?path=/docs/components-swatch-group--docs)
143+
- [React](https://react-spectrum.adobe.com/s2/index.html?path=/docs/colorswatchpicker--docs)

migration-roadmap/swatch.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ None found for this component.
132132
### DOM Structure changes
133133

134134
<details>
135-
<summary>Spectrum Web Components:</summary>
135+
<summary>Spectrum Web Components</summary>
136136

137137
```html
138138
<div class="opacity-checkerboard fill" style="--spectrum-picked-color: [color]">
@@ -145,7 +145,7 @@ None found for this component.
145145
</details>
146146

147147
<details>
148-
<summary>Legacy (CSS main branch):</summary>
148+
<summary>Legacy (CSS main branch)</summary>
149149

150150
```html
151151
<div
@@ -172,7 +172,7 @@ None found for this component.
172172
</details>
173173

174174
<details>
175-
<summary>Spectrum 2 (CSS spectrum-two branch):</summary>
175+
<summary>Spectrum 2 (CSS spectrum-two branch)</summary>
176176

177177
```html
178178
<div
@@ -237,7 +237,7 @@ No significant structural changes.
237237

238238
### CSS => SWC implementation gaps
239239

240-
**CSS Features Missing from Web Component:**
240+
**CSS features missing from Web Component:**
241241

242242
- Add swatch functionality (`.spectrum-Swatch.is-addSwatch`)
243243
- Focus state support (`.spectrum-Swatch.is-keyboardFocused`)
@@ -247,15 +247,16 @@ No significant structural changes.
247247
- Pseudo-element styling (`:before`, `:after` selectors)
248248
- Focus styling (`:focus-visible`)
249249

250-
**Web Component Features Missing from CSS:**
250+
**Web Component features missing from CSS:**
251+
251252
None found for this component.
252253

253254
### CSS Spectrum 2 changes
254255

255-
No significant structural changes between CSS main and spectrum-two branches. The templates are identical, indicating that the swatch component structure remains consistent across Spectrum 2 migration.
256+
There is a new add swatch functionality in the `spectrum-two` branch.
256257

257258
## Resources
258259

259-
- [CSS migration]()
260-
- [Spectrum 2 preview]()
261-
- [React]()
260+
- [CSS migration](https://github.com/adobe/spectrum-css/pull/3677)
261+
- [Spectrum 2 preview](https://spectrumcss.z13.web.core.windows.net/pr-2352/index.html?path=/docs/components-swatch--docs)
262+
- [React](https://react-spectrum.adobe.com/s2/index.html?path=/docs/colorswatch--docs)

migration-roadmap/thumbnail.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,18 +9,18 @@
99

1010
- `.spectrum-Thumbnail`
1111
- `.spectrum-Thumbnail--cover .spectrum-Thumbnail-image`
12+
- `.spectrum-Thumbnail--size50`
13+
- `.spectrum-Thumbnail--size75`
1214
- `.spectrum-Thumbnail--size100`
13-
- `.spectrum-Thumbnail--size1000`
1415
- `.spectrum-Thumbnail--size200`
1516
- `.spectrum-Thumbnail--size300`
1617
- `.spectrum-Thumbnail--size400`
17-
- `.spectrum-Thumbnail--size50`
1818
- `.spectrum-Thumbnail--size500`
1919
- `.spectrum-Thumbnail--size600`
2020
- `.spectrum-Thumbnail--size700`
21-
- `.spectrum-Thumbnail--size75`
2221
- `.spectrum-Thumbnail--size800`
2322
- `.spectrum-Thumbnail--size900`
23+
- `.spectrum-Thumbnail--size1000`
2424
- `.spectrum-Thumbnail-background`
2525
- `.spectrum-Thumbnail-image`
2626
- `.spectrum-Thumbnail-image-wrapper`
@@ -87,7 +87,7 @@
8787
### DOM Structure changes
8888

8989
<details>
90-
<summary>Spectrum Web Components:</summary>
90+
<summary>Spectrum Web Components</summary>
9191

9292
```html
9393
<!-- With background -->
@@ -262,14 +262,14 @@ No significant structural changes.
262262

263263
### CSS => SWC implementation gaps
264264

265-
**CSS Features Missing from Web Component:**
265+
**CSS features missing from Web Component:**
266266

267267
- Disabled state support (`.spectrum-Thumbnail.is-disabled`)
268268
- Focus state support (`.spectrum-Thumbnail.is-focused`)
269269
- Selected state support (`.spectrum-Thumbnail.is-selected`)
270270
- Pseudo-element styling (`:before`, `:after` selectors)
271271

272-
**Web Component Features Missing from CSS:**
272+
**Web Component features missing from CSS:**
273273
None found for this component.
274274

275275
### CSS Spectrum 2 changes
@@ -278,6 +278,6 @@ No significant structural changes between CSS main and spectrum-two branches. Th
278278

279279
## Resources
280280

281-
- [CSS migration]()
282-
- [Spectrum 2 preview]()
283-
- [React]()
281+
- [CSS migration](https://github.com/adobe/spectrum-css/pull/3367)
282+
- [Spectrum 2 preview](https://spectrumcss.z13.web.core.windows.net/pr-2352/index.html?path=/docs/components-thumbnail--docs)
283+
- React (no thumbnail component in React Spectrum)

0 commit comments

Comments
 (0)