feat(dialog-wrapper): implement conditional dismissHelper buttons

marissahuysentruyt · marissahuysentruyt · commit 0b1bd0ac555e · 2025-10-21T14:46:44.000-04:00
diff --git a/packages/dialog/src/DialogWrapper.ts b/packages/dialog/src/DialogWrapper.ts
@@ -125,6 +125,7 @@ export class DialogWrapper extends DialogBase {
         }
 
         return html`
+            ${this.dismissHelper}
             <sp-dialog
                 ?dismissable=${this.dismissable}
                 dismiss-label=${this.dismissLabel}
@@ -199,6 +200,7 @@ export class DialogWrapper extends DialogBase {
                       `
                     : nothing}
             </sp-dialog>
+            ${!this.dismissable ? this.dismissHelper : nothing}
         `;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,7 @@ export class DialogWrapper extends DialogBase {`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	return html`
	`128`	`+ ${this.dismissHelper}`
`128`	`129`	`<sp-dialog`
`129`	`130`	`?dismissable=${this.dismissable}`
`130`	`131`	`dismiss-label=${this.dismissLabel}`
`@@ -199,6 +200,7 @@ export class DialogWrapper extends DialogBase {`
`199`	`200`	`
`200`	`201`	`: nothing}`
`201`	`202`	`</sp-dialog>`
	`203`	`+ ${!this.dismissable ? this.dismissHelper : nothing}`
`202`	`204`	`;
`203`	`205`	`}`
`204`	`206`	`}`