Skip to content

Commit 2811b9e

Browse files
fix(status-light): add missing accent and cyan variants (#5813)
* feat(statuslight): add missing first-gen variants - added missing cyan and accent to variant list that were identified in the component analysis - correct the existing accent and cyan variant selectors - add example to docs page - create changeset - update golden hash
1 parent 19ae375 commit 2811b9e

File tree

6 files changed

+25
-10
lines changed

6 files changed

+25
-10
lines changed

.changeset/short-pans-know.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@spectrum-web-components/status-light': patch
3+
---
4+
5+
**Fixed**: Added missing `accent` and `cyan` variant to status light.

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ parameters:
2222
# 3. Commit this change to the PR branch where the changes exist.
2323
current_golden_images_hash:
2424
type: string
25-
default: 1bd7e9973de8f318233aa41b5b8a97a2956cd44d
25+
default: 13c4ec984fd6880ccc8dde9dd23f22d6b4337969
2626
wireit_cache_name:
2727
type: string
2828
default: wireit

packages/status-light/README.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,11 @@ Status lights come in various semantic and non-semantic variants to convey diffe
8080
<sp-tab-panel value="semantic">
8181

8282
```html
83-
<sp-status-light variant="neutral">
84-
use for default state
85-
</sp-status-light>
83+
<sp-status-light variant="neutral">use for default state</sp-status-light>
8684
<sp-status-light variant="positive">
8785
use for success or approval
8886
</sp-status-light>
89-
<sp-status-light variant="negative">
90-
use for error or rejection
91-
</sp-status-light>
87+
<sp-status-light variant="negative">use for error or rejection</sp-status-light>
9288
<sp-status-light variant="notice">
9389
use for warning or attention needed
9490
</sp-status-light>
@@ -110,6 +106,7 @@ Status lights come in various semantic and non-semantic variants to convey diffe
110106
<sp-status-light variant="magenta">magenta status</sp-status-light>
111107
<sp-status-light variant="celery">celery status</sp-status-light>
112108
<sp-status-light variant="purple">purple status</sp-status-light>
109+
<sp-status-light variant="cyan">cyan status</sp-status-light>
113110
```
114111

115112
</sp-tab-panel>

packages/status-light/src/StatusLight.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ export class StatusLight extends SizedMixin(SpectrumElement, {
4444
*/
4545
@property({ reflect: true })
4646
public variant:
47+
| 'accent'
4748
| 'negative'
4849
| 'notice'
4950
| 'positive'
@@ -56,7 +57,8 @@ export class StatusLight extends SizedMixin(SpectrumElement, {
5657
| 'chartreuse'
5758
| 'magenta'
5859
| 'celery'
59-
| 'purple' = 'info';
60+
| 'purple'
61+
| 'cyan' = 'info';
6062

6163
protected override render(): TemplateResult {
6264
return html`

packages/status-light/src/spectrum-status-light.css

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
--spectrum-statuslight-nonsemantic-purple-color: var(--spectrum-purple-visual-color);
8080
--spectrum-statuslight-nonsemantic-fuchsia-color: var(--spectrum-fuchsia-visual-color);
8181
--spectrum-statuslight-nonsemantic-magenta-color: var(--spectrum-magenta-visual-color);
82+
8283
min-block-size: var(--mod-statuslight-height, var(--spectrum-statuslight-height));
8384
box-sizing: border-box;
8485
font-size: var(--mod-statuslight-font-size, var(--spectrum-statuslight-font-size));
@@ -102,6 +103,7 @@
102103

103104
:host:before {
104105
--spectrum-statuslight-spacing-computed-top-to-dot: calc(var(--mod-statuslight-spacing-top-to-dot, var(--spectrum-statuslight-spacing-top-to-dot)) - var(--mod-statuslight-spacing-top-to-label, var(--spectrum-statuslight-spacing-top-to-label)));
106+
105107
content: "";
106108
inline-size: var(--mod-statuslight-dot-size, var(--spectrum-statuslight-dot-size));
107109
block-size: var(--mod-statuslight-dot-size, var(--spectrum-statuslight-dot-size));
@@ -122,7 +124,7 @@
122124
background-color: var(--mod-statuslight-semantic-neutral-color, var(--spectrum-statuslight-semantic-neutral-color));
123125
}
124126

125-
.spectrum-StatusLight--accent:before {
127+
:host([variant="accent"]):before {
126128
background-color: var(--mod-statuslight-semantic-accent-color, var(--spectrum-statuslight-semantic-accent-color));
127129
}
128130

@@ -174,7 +176,7 @@
174176
background-color: var(--mod-statuslight-nonsemantic-seafoam-color, var(--spectrum-statuslight-nonsemantic-seafoam-color));
175177
}
176178

177-
.spectrum-StatusLight--cyan:before {
179+
:host([variant="cyan"]):before {
178180
background-color: var(--mod-statuslight-nonsemantic-cyan-color, var(--spectrum-statuslight-nonsemantic-cyan-color));
179181
}
180182

@@ -202,6 +204,7 @@
202204
:host([dir]) {
203205
--highcontrast-statuslight-content-color-default: CanvasText;
204206
--highcontrast-statuslight-subdued-content-color-default: CanvasText;
207+
205208
forced-color-adjust: none;
206209
}
207210

packages/status-light/stories/status-light.stories.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ export default {
1919
};
2020

2121
export const s = (): TemplateResult => html`
22+
<sp-status-light size="s" variant="accent">accent</sp-status-light>
2223
<sp-status-light size="s" variant="positive">positive</sp-status-light>
2324
<sp-status-light size="s" variant="negative">negative</sp-status-light>
2425
<sp-status-light size="s" variant="notice">notice</sp-status-light>
@@ -32,9 +33,11 @@ export const s = (): TemplateResult => html`
3233
<sp-status-light size="s" variant="magenta">magenta</sp-status-light>
3334
<sp-status-light size="s" variant="celery">celery</sp-status-light>
3435
<sp-status-light size="s" variant="purple">purple</sp-status-light>
36+
<sp-status-light size="s" variant="cyan">cyan</sp-status-light>
3537
`;
3638

3739
export const m = (): TemplateResult => html`
40+
<sp-status-light size="m" variant="accent">accent</sp-status-light>
3841
<sp-status-light size="m" variant="positive">positive</sp-status-light>
3942
<sp-status-light size="m" variant="negative">negative</sp-status-light>
4043
<sp-status-light size="m" variant="notice">notice</sp-status-light>
@@ -48,9 +51,11 @@ export const m = (): TemplateResult => html`
4851
<sp-status-light size="m" variant="magenta">magenta</sp-status-light>
4952
<sp-status-light size="m" variant="celery">celery</sp-status-light>
5053
<sp-status-light size="m" variant="purple">purple</sp-status-light>
54+
<sp-status-light size="m" variant="cyan">cyan</sp-status-light>
5155
`;
5256

5357
export const l = (): TemplateResult => html`
58+
<sp-status-light size="l" variant="accent">accent</sp-status-light>
5459
<sp-status-light size="l" variant="positive">positive</sp-status-light>
5560
<sp-status-light size="l" variant="negative">negative</sp-status-light>
5661
<sp-status-light size="l" variant="notice">notice</sp-status-light>
@@ -64,9 +69,11 @@ export const l = (): TemplateResult => html`
6469
<sp-status-light size="l" variant="magenta">magenta</sp-status-light>
6570
<sp-status-light size="l" variant="celery">celery</sp-status-light>
6671
<sp-status-light size="l" variant="purple">purple</sp-status-light>
72+
<sp-status-light size="l" variant="cyan">cyan</sp-status-light>
6773
`;
6874

6975
export const XL = (): TemplateResult => html`
76+
<sp-status-light size="xl" variant="accent">accent</sp-status-light>
7077
<sp-status-light size="xl" variant="positive">positive</sp-status-light>
7178
<sp-status-light size="xl" variant="negative">negative</sp-status-light>
7279
<sp-status-light size="xl" variant="notice">notice</sp-status-light>
@@ -80,6 +87,7 @@ export const XL = (): TemplateResult => html`
8087
<sp-status-light size="xl" variant="magenta">magenta</sp-status-light>
8188
<sp-status-light size="xl" variant="celery">celery</sp-status-light>
8289
<sp-status-light size="xl" variant="purple">purple</sp-status-light>
90+
<sp-status-light size="xl" variant="cyan">cyan</sp-status-light>
8391
`;
8492

8593
export const disabledTrue = (): TemplateResult => html`

0 commit comments

Comments
 (0)