Skip to content

Commit 95760d1

Browse files
docs(checkbox, field-group): update migration roadmap
- gives clarification on invalid checkbox consideration - clarifies some of the implementation gaps for field group
1 parent 68b3d3a commit 95760d1

File tree

2 files changed

+15
-13
lines changed

2 files changed

+15
-13
lines changed

migration-roadmap/checkbox.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,9 @@ None found for this component.
265265
### CSS => SWC implementation gaps
266266

267267
**New for S2:**
268-
The checkbox component in Spectrum 2 has the new down state (active) perspective shift applied. Additionally, the checkbox CSS was expanded to ensure coverage of a variety of interactive and variant states: hover, focus-visible, hover+disabled, checked+disabled, focus-visible+checked+hover, indeterminate+invalid, invalid+focused, disabled+read-only, etc.
268+
The checkbox component in Spectrum 2 has the new down state (active) perspective shift applied.
269+
270+
Note: There is some discussion ongoing about the invalid styles for checkbox. Currently, CSS supports individual red borders on the checkbox component, however, these styles are not present in the Figma specs for checkbox. The only invalid styling supported by design is the negative help text found in the field group component. When migrating, we'll need to consider clarifying the invalid styling with the design team for individual checkboxes.
269271

270272
**Features Missing from CSS:**
271273

migration-roadmap/field-group.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -205,24 +205,24 @@ None found for this component.
205205

206206
### CSS => SWC mapping
207207

208-
| CSS selector | Attribute or slot | Status |
209-
| ---------------------------------- | ------------------------------------ | ------------------------------ |
210-
| `.spectrum-FieldGroup` | :host | Implemented |
211-
| `.spectrum-FieldGroup--horizontal` | `horizontal` attribute | Implemented |
212-
| `.spectrum-FieldGroup--vertical` | Default variant; `vertical attribute | Implemented |
213-
| `.spectrum-FieldGroup--sidelabel` | Layout variant | Missing from WC |
214-
| `.spectrum-FieldGroup--toplabel` | Layout variant | Missing from WC |
215-
| `.spectrum-FieldGroupInputLayout` | Internal layout container | Missing from WC |
216-
| `.spectrum-FieldGroup-item` | Individual field item classes | Missing from WC |
217-
| `.spectrum-HelpText` | Help text styling | Implemented via `sp-help-text` |
208+
| CSS selector | Attribute or slot | Status |
209+
| ---------------------------------- | ------------------------------------- | ------------------------------------ |
210+
| `.spectrum-FieldGroup` | `:host` | Implemented |
211+
| `.spectrum-FieldGroup--horizontal` | `horizontal` attribute | Implemented |
212+
| `.spectrum-FieldGroup--vertical` | Default variant; `vertical` attribute | Implemented |
213+
| `.spectrum-FieldGroup--sidelabel` | Layout variant | Missing from WC (implementation gap) |
214+
| `.spectrum-FieldGroup--toplabel` | Layout variant | Missing from WC (implementation gap) |
215+
| `.spectrum-FieldGroupInputLayout` | Internal layout container | Missing from WC (implementation gap) |
216+
| `.spectrum-FieldGroup-item` | Individual field item classes | Missing from WC (implementation gap) |
217+
| `.spectrum-HelpText` | Help text styling | Implemented via `sp-help-text` |
218218

219219
## Summary of changes
220220

221221
### CSS => SWC implementation gaps
222222

223223
- In CSS, the field label is incorporated into the field group component in both S1 and S2, however `<sp-field-group>` does not have a slot for a corresponding `<sp-field-label>`. Because of this, `<sp-field-group>` doesn't technically support `.spectrum-FieldGroup--sidelabel` and `.spectrum-FieldGroup--toplabel` layout variants. However, `<sp-field-label>` can be defined as top- or side-aligned, so we may be able to reevaluate if this behavior can be supported.
224-
- `.spectrum-FieldGroupInputLayout` wrapper container is not generated by the web component.
225-
- `.spectrum-FieldGroup-item` classes are not automatically applied to slotted elements.
224+
- `.spectrum-FieldGroupInputLayout` wrapper container is not generated by the web component. This class is the flex container that orients the items vertically or horizontally.
225+
- `.spectrum-FieldGroup-item` classes are not automatically applied to slotted elements. The class provides the appropriate spacing between items.
226226

227227
### CSS Spectrum 2 changes
228228

0 commit comments

Comments
 (0)