You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: migration-roadmap/checkbox.md
+3-1Lines changed: 3 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -265,7 +265,9 @@ None found for this component.
265
265
### CSS => SWC implementation gaps
266
266
267
267
**New for S2:**
268
-
The checkbox component in Spectrum 2 has the new down state (active) perspective shift applied. Additionally, the checkbox CSS was expanded to ensure coverage of a variety of interactive and variant states: hover, focus-visible, hover+disabled, checked+disabled, focus-visible+checked+hover, indeterminate+invalid, invalid+focused, disabled+read-only, etc.
268
+
The checkbox component in Spectrum 2 has the new down state (active) perspective shift applied.
269
+
270
+
Note: There is some discussion ongoing about the invalid styles for checkbox. Currently, CSS supports individual red borders on the checkbox component, however, these styles are not present in the Figma specs for checkbox. The only invalid styling supported by design is the negative help text found in the field group component. When migrating, we'll need to consider clarifying the invalid styling with the design team for individual checkboxes.
|`.spectrum-FieldGroup--sidelabel`| Layout variant | Missing from WC (implementation gap)|
214
+
|`.spectrum-FieldGroup--toplabel`| Layout variant | Missing from WC (implementation gap)|
215
+
|`.spectrum-FieldGroupInputLayout`| Internal layout container | Missing from WC (implementation gap)|
216
+
|`.spectrum-FieldGroup-item`| Individual field item classes | Missing from WC (implementation gap)|
217
+
|`.spectrum-HelpText`| Help text styling | Implemented via `sp-help-text`|
218
218
219
219
## Summary of changes
220
220
221
221
### CSS => SWC implementation gaps
222
222
223
223
- In CSS, the field label is incorporated into the field group component in both S1 and S2, however `<sp-field-group>` does not have a slot for a corresponding `<sp-field-label>`. Because of this, `<sp-field-group>` doesn't technically support `.spectrum-FieldGroup--sidelabel` and `.spectrum-FieldGroup--toplabel` layout variants. However, `<sp-field-label>` can be defined as top- or side-aligned, so we may be able to reevaluate if this behavior can be supported.
224
-
-`.spectrum-FieldGroupInputLayout` wrapper container is not generated by the web component.
225
-
-`.spectrum-FieldGroup-item` classes are not automatically applied to slotted elements.
224
+
-`.spectrum-FieldGroupInputLayout` wrapper container is not generated by the web component. This class is the flex container that orients the items vertically or horizontally.
225
+
-`.spectrum-FieldGroup-item` classes are not automatically applied to slotted elements. The class provides the appropriate spacing between items.
0 commit comments