Esc key does not dismiss dialog opened with sp-dialog-wrapper

[davidclark87]

Expected Behaviour

Pressing Esc key should close a modal dialog. Since the dialog could be opened via keyboard, it should be dismissable via keyboard.

Actual Behaviour

Pressing Esc has no effect. Workaround is to click the X in the top right corner or outside of the dialog area to dismiss it.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

1. Go to https://opensource.adobe.com/spectrum-web-components/components/dialog-wrapper
2. Click the first Toggle Dialog button on the page (under the "Small" Example)
3. With the dialog now open, try pressing Esc. Nothing happens
   

Platform and Version

Tested on Chrome 87 (Mac)

Sample Code that illustrates the problem

See docs

Logs taken while reproducing problem

N/A

[Westbrook]

This is outlined in #710 and #866, but the functionality here exists, but is not yet being used in the documentation site for this element. Great to have it called out so clearly, however, so thanks!

[davidclark87]

@Westbrook sorry I'm not following - doesn't this behavior on the documentation site imply the component has an a11y issue, at least when configured with the options shown?

Is the point that those options are actually invalid or deprecated with respect to the current component API?