Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: dismissing an overlay twice, quickly, breaks the overlay in question #2646

Closed
1 task done
hunterloftis opened this issue Oct 6, 2022 · 2 comments · Fixed by #2663
Closed
1 task done

[Bug]: dismissing an overlay twice, quickly, breaks the overlay in question #2646

hunterloftis opened this issue Oct 6, 2022 · 2 comments · Fixed by #2663
Labels
bug Something isn't working Component: Overlay triage An issue needing triage

Comments

@hunterloftis
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

overlay,dialog

Expected behavior

Pressing escape N times, or clicking on an underlay N times, no matter how fast, does not impact the future behavior of overlays.

Actual behavior

Pressing escape twice or clicking on an underlay twice, quickly, can prevent future overlays from opening.

Screenshots

overlay-esc-bug.mov

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/dialog-wrapper/
  2. Click "toggle dialog"
  3. Double-click on its underlay quickly
  4. Click "toggle dialog"
  5. Notice that no dialog opens

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@hunterloftis hunterloftis added bug Something isn't working triage An issue needing triage Component: Overlay labels Oct 6, 2022
@Westbrook
Copy link
Contributor

Seems like there should be a pretty direct way to gate this duplication on state under the covers.

@najikahalsema najikahalsema changed the title [Bug]: dismissing an overlay twice, quickly, breaks the overlay system [Bug]: dismissing an overlay twice, quickly, breaks the overlay in question Oct 13, 2022
@najikahalsema
Copy link
Collaborator

The overlay may not be prepared to accept a close event while it's awaiting a promise or some other async event... Should investigate the underlying cause and if this relates to the lifecycle of the component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Overlay triage An issue needing triage
Projects
None yet
3 participants