-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Overlay]: update and expand documentation #2657
Comments
@najikahalsema does it make sense to split this issue up into the pieces of have yet to be addressed for easier consumption by contributors and the team? I think 1, 2 and 5 might no longer be needed (post v2), but please use your judgement. |
I agree with you. I wonder if we would also still need to document the focus and positioning, though. Unfortunately, past Najika was not so verbose and I'm wondering what I meant, exactly. We have some documenting of the positioning and focus in the Imperative API docs. Do we feel this is sufficient? |
|
@TarunAdobe with your upcoming presentation on the inner working of the Overlay API, I'd really appreciate your thoughts on how best to expand our documentation coverage of this API. |
YESSSS!!!. I'll keep that in mind. |
@TarunAdobe do you think your recent updates here complete the requests outlined herein, or is there further work to be done before this issue can be closed? |
completed via #3971 |
Code of conduct
Description of issue
Our overlay component is pretty complex, and our docs should cover those complexities. When we did a walkthrough of how to consume this component, there were a few things that weren't clear in the documentation. I think it would be great if we could write these docs in plain language and include examples for all the different usages we outline. Some specific things I noticed:
TriggerInteraction
example is using'click'
, but what we discussed pointed to'modal'
being the most accessible interaction to use. This isn't clear, and if I were a consumer, I would probably default to'click'
since that's the example the docs give me. Some further description of the different types of interactions would help our consumers decide which is best for their use case.<style>
tag, and usage of css. Including examples for each.VirtualTrigger()
.The text was updated successfully, but these errors were encountered: