Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(sp-picker): Picker doesn't close on scroll and is switching placement because of that #2904

Closed
1 task done
najikahalsema opened this issue Feb 6, 2023 · 3 comments
Closed
1 task done
Labels
bug Something isn't working Component: Overlay Component: Picker Post overlay API Review after Overlay V2 Ships

Comments

@najikahalsema
Copy link
Collaborator

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-picker, overlay

Expected behavior

Placement should maintain its location.

Actual behavior

The overlay isn't closing upon scrolling, which causes the overlay to shift from bottom placement to the top.

Screenshots

sp-picker-production.mov

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@najikahalsema
Copy link
Collaborator Author

cc @pwong09

@pwong09
Copy link

pwong09 commented Feb 6, 2023

The other issue with sp-picker is the way the overlay's height increases (presumably forever) while the user scrolls down the main webpage due to its height set to 100%. I had expected the overlay's height to stay static while I scroll outside of it.

@najikahalsema najikahalsema added the Post overlay API Review after Overlay V2 Ships label Mar 9, 2023
@Westbrook Westbrook mentioned this issue Jul 17, 2023
21 tasks
@Westbrook
Copy link
Contributor

As of #3456 the <sp-picker> and related elements close on scroll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Overlay Component: Picker Post overlay API Review after Overlay V2 Ships
Projects
None yet
Development

No branches or pull requests

3 participants