Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]: tooltip for action-menu #2916

Closed
1 task done
spdev3000 opened this issue Feb 8, 2023 · 3 comments
Closed
1 task done

[Feat]: tooltip for action-menu #2916

spdev3000 opened this issue Feb 8, 2023 · 3 comments
Labels
Component: Action Menu enhancement New feature or request Post overlay API Review after Overlay V2 Ships

Comments

@spdev3000
Copy link
Collaborator

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

ActionMenu

Description of the requested feature

We'd like to use sp-tooltip in combination with an ActionMenu, in theory this works with extra <overlay-wrapper> where <sp-action-menu> triggers the hover-content with <sp-tooltip> in it.
However that leads to flickering issues when the action-menu was open and after it has been closed.
Ideally ActionMenu would provide a slot=tooltip (or similar) to provide such an tooltip when hovering over the trigger item of that ActionMenu.

Mockups or screenshots

No response

Implementation notes or ideas

No response
@spdev3000 spdev3000 added enhancement New feature or request Component: Action Menu triage An issue needing triage labels Feb 8, 2023
@spdev3000 spdev3000 changed the title [Feat]: sp-tooltip for action-menu [Feat]: tooltip for action-menu Feb 8, 2023
@najikahalsema najikahalsema added Post overlay API Review after Overlay V2 Ships and removed triage An issue needing triage labels Mar 9, 2023
@Westbrook Westbrook mentioned this issue Jul 17, 2023
Merged
21 tasks
@anishAdobe anishAdobe mentioned this issue Jul 25, 2023
Merged
13 tasks
@Westbrook
Copy link
Contributor

@anishAdobe the slot="tooltip" approach here seems like it would be a better idea than taking attributes for this content. It would afford full API support for the Tooltip (placement, delay, etc.) while also allowing full HTML content (keyboard shortcuts, or similar) within the Tooltip.

@anishAdobe
Copy link
Contributor

Updated the PR with required changes.

@Westbrook
Copy link
Contributor

Fixed by #3488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Action Menu enhancement New feature or request Post overlay API Review after Overlay V2 Ships
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Westbrook @spdev3000 @najikahalsema @anishAdobe