Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat][a11y]: sp-dialog: use HTMLDialogElement with show() or showModal() method #3374

Closed
1 task done
majornista opened this issue Jun 27, 2023 · 1 comment
Closed
1 task done

[Feat][a11y]: sp-dialog: use HTMLDialogElement with show() or showModal() method #3374

majornista opened this issue Jun 27, 2023 · 1 comment
Labels
a11y Issues related to accessibility Component: Dialog Component: Overlay enhancement New feature or request triage An issue needing triage

Comments

@majornista
Copy link
Contributor

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Dialog, DialogBase, DialogWrapper, Overlay

Description of the requested feature

Dialog component should use modern HTML5 <dialog> component, which automatically traps keyboard focus, handles z-index positioning, and makes underlying content inert.

Mockups or screenshots

No response

Implementation notes or ideas

No response
@majornista majornista added enhancement New feature or request triage An issue needing triage Component: Overlay a11y Issues related to accessibility Component: Dialog labels Jun 27, 2023
@Westbrook
Copy link
Contributor

Closing as a duplicate of #2086 and the work going on in #3009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y Issues related to accessibility Component: Dialog Component: Overlay enhancement New feature or request triage An issue needing triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@majornista @Westbrook