Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Closing tooltip causes complete overlay chain to close too #3418

Closed
1 task done
spdev3000 opened this issue Jul 7, 2023 · 1 comment · Fixed by #3456
Closed
1 task done

[Bug]: Closing tooltip causes complete overlay chain to close too #3418

spdev3000 opened this issue Jul 7, 2023 · 1 comment · Fixed by #3456
Labels
bug Something isn't working Component: Overlay Component: Tooltip Overlay v2 Confirmed Post overlay API Review after Overlay V2 Ships triage An issue needing triage

Comments

@spdev3000
Copy link
Collaborator

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Overlay, Tooltip

Expected behavior

When we have chained overlays (example: overlay in an overlay) with an action-button in the inner overlay, that has an self-managed tooltip - clicking this action-button should close the tooltip BUT should not close the complete overlay chain.

Actual behavior

Closing the tooltip causes closing the whole overlay chain.

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to webcomponents example
  2. Click on button to trigger first level overlay
  3. Click on button inside that first level overlay to trigger second level
  4. Hover over 1st action-button to reveal tooltip
  5. Click action-button
  6. See tooltip dimissing, AND all overlays too

Sample code that illustrates the problem

https://studio.webcomponents.dev/edit/KJk8hzeTyHX3yVtDCkQP/src/index.ts?p=stories

Logs taken while reproducing problem

No response

@spdev3000 spdev3000 added bug Something isn't working Component: Overlay Component: Tooltip triage An issue needing triage labels Jul 7, 2023
@Westbrook Westbrook added the Post overlay API Review after Overlay V2 Ships label Jul 14, 2023
@Westbrook
Copy link
Contributor

This is looking good with the new Overlay API. I'll look into adding specific support for this interaction to our test suite to ensure we don't regress in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Component: Overlay Component: Tooltip Overlay v2 Confirmed Post overlay API Review after Overlay V2 Ships triage An issue needing triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants