Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Orchestrators - Merge its Functionality into Organizers #129

Closed
adomokos opened this issue Dec 31, 2017 · 0 comments
Closed

Remove Orchestrators - Merge its Functionality into Organizers #129

adomokos opened this issue Dec 31, 2017 · 0 comments

Comments

@adomokos
Copy link
Owner

The idea of Orchestrators was born when we had way too much logic in a Rails controller action. It made a lot of sense then and there, but as we used it more, we realized it just has unnecessary complexity.

I'd like to kill Orchestrators and add all its functionality to Organizers, that way an Orchestrator could be a series of Actions:

[
  FindsClientAction,
  SubmitsOrderAction,
  SendsNotificationsAction
]

or have more complex workflows:

[
  FindsClientsAction,
  iterates(:clients, [
    MarksClientInactive,
    SendsNotificationAction
   ]
]

All this work is happening in the 1.0 branch,
and it won't be backward compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant