Should global scopes of pivot model be applied?

[radmen]

Here's quite interesting case.

First I'll try to give valid example code (based on docs):

App/Models/User

class User extends Model {
    ownedCars () {
        return this.belongsToMany('App/Models/Car')
            .pivotModel('App/Models/OwnerCar')
    }
}

App/Models/OwnerCar

class OwnerCar extends Model {
    static boot () {
        super.boot()
        this.addHook('beforeCreate', (userCar) => {
            userCar.is_current_owner = true
        })
        this.addGlobalScope(
            (query) => {
                query.where({ is_current_owner: true })
            }
        )
    }
}

Attaching car to user (using ownedCars()) will set properly is_current_owner flag.

After few hours of hard debugging I've found out that global scope is applied when using attach(), detach() yet it's not the case when I'm trying to use eg fetch() or count(). Same goes for eager loads (with('ownedCars') or load('ownedCars'))

I've dwelled into the code and it looks that global scope is not applied to data which is loaded eagerly.

Should global scope be applied when fetching data?
One thing I from the code I can tell is that it won't be that easy to implement.

[thetutlage]

Seems like a bug by looking at first glance, lemme get into it in more depth later

[thetutlage]

@radmen Mind testing same by installing lucid from Github?

[radmen]

@thetutlage is this update released on NPM? I've checked version 4.1.1 and the bug still occurs.

[thetutlage]

Nope, that's why I said try it from Github

[radmen]

Ah, sorry. Will check it now.

[radmen]

Fix still fails in my project.

Later (hopefully in next days) I'll prepare a clean Adonis installation and will try to reproduce it here.

[radmen]

@thetutlage I've prepared an example app which allows to reproduce the problem: https://github.com/radmen/adonis-lucid-pivot-global-scopes

[thetutlage]

Looked at the repo, the global scope should be added to the Car model, since all the fetch queries are made using this model, the pivotModel is used only for attach, detach and sync calls.

[tlgreg]

I might be misunderstanding something.
How would you do that?
The constraint is on the pivot and the scope is only make sense through the relation.

[thetutlage]

Yes I believe the relationship should apply scopes from the pivot model when defined. Thinking of other relations too 🤔