Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace faker with the new @faker-js/faker stable fork #759

Closed
rubenmoya opened this issue Jan 14, 2022 · 7 comments
Closed

Replace faker with the new @faker-js/faker stable fork #759

rubenmoya opened this issue Jan 14, 2022 · 7 comments
Assignees
Labels
Good First Issue Want to contribute? Just filter by this label Priority: High Look into this issue before picking up any new work Semver: Minor Mainly new features and improvements

Comments

@rubenmoya
Copy link

Why this feature is required (specific use-cases will be appreciated)?

This tweet from Romain sums up what happened:

It seems that @marak has been hacked.

Faker repository is gone, release 6.6.6 which is empty.
At least, it seems nothing malicious was added inside this release.

It could have been really worse.https://t.co/z7RjyGOA64https://t.co/5LIfjdt1Pp

— Romain Lanz 🦊🌖 (@RomainLanz) January 5, 2022

A lot of forks were created the days after that, but some people worked on unifying them and dealing with all the problems:

For the last 3 days I've been working on Faker and dealing with the fallout. The package. The docs. The Open Collective. Please follow the @faker_js account for an official statement in the next day.

Maintainers are now @damienwebdev @Shini_92 @_prisis_ @mmahalwy griest + myself

— jess (@_jessicasachs) January 12, 2022

This are the links to the project:

Repository: https://github.com/faker-js/faker
Twitter: https://twitter.com/faker_js

Have you tried any other work arounds?

We could just keep the current version, but I just wanted to have this issue as a reminder that we need to update it.

Are you willing to work on it with little guidance?

Sure!

@RomainLanz
Copy link
Member

Hey @rubenmoya! 👋🏻

I believe @thetutlage planned to write another Faker-like package with a better API, but I agree that we should migrate off Faker in the meanwhile.

I will look at this new fork and see how it can be integrated without breaking changes.

@thetutlage
Copy link
Member

Yeah, if this new package is a drop-in replacement, then we should go ahead and update the dependency

@rubenmoya
Copy link
Author

Do you want me to give it a try? Or do you prefer to change it yourselves?

@thetutlage
Copy link
Member

Sure! Feel free to send a PR for the same

@RomainLanz
Copy link
Member

Are you still willing to work on it @rubenmoya?

@rubenmoya
Copy link
Author

I'm sorry I do not have enough time right now to focus on it :(

@RomainLanz RomainLanz added Good First Issue Want to contribute? Just filter by this label Priority: High Look into this issue before picking up any new work Semver: Minor Mainly new features and improvements labels Feb 18, 2022
@thetutlage
Copy link
Member

Done in #791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Want to contribute? Just filter by this label Priority: High Look into this issue before picking up any new work Semver: Minor Mainly new features and improvements
Projects
None yet
Development

No branches or pull requests

3 participants