loadCount method change the model attributes

[thetutlage]

Discussed in adonisjs/core#3441

^{Originally posted by farshadfahimi December 25, 2021}
I have a simple model like below

import { DateTime } from 'luxon'
import {
  BaseModel,
  column,
  HasMany,
  hasMany,
  scope,
} from '@ioc:Adonis/Lucid/Orm'
import Product from 'App/Models/Product'

type PropertiesJson = {
  landing_categories: object
}

export default class Brand extends BaseModel {
  public serializeExtras = true

  @column({ isPrimary: true })
  public id: number

  @column()
  public name: string

  @column()
  public slug: string

  @column()
  public description: string | null

  @column.dateTime({ autoCreate: true, autoUpdate: true })
  public updatedAt: DateTime

  @hasMany(() => Product, {
    foreignKey: 'brandsId',
  })
  public products: HasMany<typeof Product>

}

and in the controller just fetch the one model from database

public async show({ params }: HttpContextContract) {
    const brand = await Brand.findOrFail(params.id)
    
    // await brand.loadCount('products')
    console.log(brand)
    return brand.serialize()
  }

the result of console in the controller is some thing like below

Brand {
  modelOptions: {
    connection: 'mysql',
    profiler: Profiler {
      appRoot: '/var/www/fafait/adonis-api',
      logger: [Logger],
      config: [Object]
    }
  },
  modelTrx: undefined,
  transactionListener: [Function: bound listener],
  fillInvoked: false,
  cachedGetters: {},
  '$columns': {},
  '$attributes': {
    id: 1,
    name: 'apple',
    slug: 'apple',
    updatedAt: DateTime {
      ts: 1618823508000,
      _zone: SystemZone {},
      loc: [Locale],
      invalid: null,
      weekData: null,
      c: [Object],
      o: 270,
      isLuxonDateTime: true
    }
  },
  '$original': {
    id: 1,
    name: 'apple',
    slug: 'apple',
    updatedAt: DateTime {
      ts: 1618823508000,
      _zone: SystemZone {},
      loc: [Locale],
      invalid: null,
      weekData: null,
      c: [Object],
      o: 270,
      isLuxonDateTime: true
    }
  },
  '$preloaded': {},
  '$sideloaded': {},
  '$isPersisted': true,
  '$isDeleted': false,
  '$isLocal': false,
  serializeExtras: true
}

but when uncomment await brand.loadCount('products') from controller the result o console change to

Brand {
  modelOptions: {
    connection: 'mysql',
    profiler: Profiler {
      appRoot: '/var/www/fafait/adonis-api',
      logger: [Logger],
      config: [Object]
    }
  },
  modelTrx: undefined,
  transactionListener: [Function: bound listener],
  fillInvoked: false,
  cachedGetters: {},
  '$columns': {},
  '$attributes': { id: 1 },
  '$original': { id: 1 },
  '$preloaded': {},
  '$extras': { products_count: 531 },
  '$sideloaded': {},
  '$isPersisted': true,
  '$isDeleted': false,
  '$isLocal': false,
  serializeExtras: true
}

as you can see the $attributes property data is changed and remove model properties and just save the id for use in eager loading
and if the controller code change to something like below and use withCount problem is solved

public async show({ params }: HttpContextContract) {
    const brand = await Brand.query().withCount('products').where({ id: params.id }).firstOrFail()

    return brand.serialize()
  }
```</div>

[thetutlage]

It is a bug. Confirmed it on Discord