Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ember-cli v3.4 #86

Open
toranb opened this issue Aug 29, 2018 · 6 comments
Open

Support for ember-cli v3.4 #86

toranb opened this issue Aug 29, 2018 · 6 comments

Comments

@toranb
Copy link
Collaborator

toranb commented Aug 29, 2018

Ember 3.4 stable was released today and seems to be working fine w/ ember-cli v3.3.0

toranb/ember-hot-reload-demo@3d25f9d

That said, I manually tested with ember-cli v3.4.0-beta.3 today and it's not live/or hot reloading at the moment (maybe? because of this PR that landed recently)

@toranb
Copy link
Collaborator Author

toranb commented Sep 16, 2018

A little follow up - found that I need to craft a web socket connection to push an event to the client w/ the changed information we sent previously over http as shown below. I'll dive into this after my talk next week :)

http://localhost:7020/changed?files=/foo/bar

@GCorbel
Copy link

GCorbel commented Oct 13, 2018

I have the same issue. Any update?

@toranb
Copy link
Collaborator Author

toranb commented Oct 13, 2018

@GCorbel thanks for keeping me honest! I’ve got Friday the 19th off and plan to dive in before lunch (as I’ve ignored this otherwise). Thanks for bringing it to my attention today!

@GCorbel
Copy link

GCorbel commented Oct 14, 2018

Thanks, let me know if I can help.

@toranb
Copy link
Collaborator Author

toranb commented Oct 19, 2018

I've also noticed a break when using the latest ember-resolver v5.0.1 (looking into that along w/ the web socket issue). This commit specifically broke the world (for reference).

@toranb
Copy link
Collaborator Author

toranb commented Oct 19, 2018

@GCorbel I burned a good deal of the day just looking into the resolver issues and came away empty handed. I think this addon now has 2 defects worth tracking that need fixed to get this functional again for ember-cli > 3.3

I'll open an issue for the resolver work but if you have some bandwidth to help triage and fix this web socket regression I'd welcome it. I don't set aside much OSS time for this addon anymore personally but I still think it offers a lot of raw productivity when it is functional.

I'm happy to hand this off to you/ or anyone else who might have more dedicated time to restore it. I've also reached out to someone within a bigger company to pitch them on taking it over (and giving it the dedication it needs to survive).

Apologies for my lack of finish today -let me know if you decide to jump in and hack away on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants