Validate on runs validation on all attributes

[kat3kasper]

I'm wondering why when using on during validate, validate still validates each attr and only stores the results of those whitelisted. This seems like unnecessary processing. Why not only run the validation if on is not defined or the attr is specified.

function validate(options = {}, async = true) {
  var model = get(this, 'model');
  var whiteList = makeArray(options.on);
  var blackList = makeArray(options.excludes);
  var validationResult, value;

  var validationResults = get(this, '_validatableAttributes').reduce((v, name) => {

    if (!isEmpty(blackList) && blackList.indexOf(name) !== -1) {
      return v;
    }

    if (isEmpty(whiteList) || whiteList.indexOf(name) !== -1) {
      validationResult = get(this, `attrs.${name}`);

     // If an async validation is found, throw an error
     if (!async && get(validationResult, 'isAsync')) {
       throw new Error(`[ember-cp-validations] Synchronous validation failed due to ${name} being an async validation.`);
     }

      value = get(validationResult, 'value');
      v.push(validationResult);
    }
    return v;
  }, []);

  var validationResultsCollection = ValidationResultCollection.create({
    content: validationResults
  });

  var resultObject = {
    model,
    validations: validationResultsCollection
  };

  if (async) {
    if (get(validationResultsCollection, 'isAsync')) {
      resultObject.promise = get(validationResultsCollection, 'value');
    }
    return RSVP.hash(resultObject);
  }

  return resultObject;
}

[offirgolan]

Im not sure I'm understanding you question but if on is provided, we only validate the attributes that are given in that collection

 if (isEmpty(whiteList) || whiteList.indexOf(name) !== -1) { ... }

[kat3kasper]

That is the thing we don't only validate the attributes that are in the given collection. We validate all the attributes but only return the results of the whitelisted attributes.

The original validate calls validationResult = get(this, 'attrs.${name}'); on all attributes then if whitelisted adds the results to validationResults.

My updated code above only runs the validations if the attribute is whitelisted.

[offirgolan]

Oh you posted modified code! I thought that was the original code lol.

I see what you mean! I'll make the change 😸

[offirgolan]

Thanks for creating the issue and bringing this to my attention!

[kat3kasper]

If you add this to the CHANGELOG can you attribute it to me? thank you

[stefanpenner]

good catch

[offirgolan]

Fixed with v2.4.1, attributed you in the changelog as well 😄