Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to allow row selection without ctrl/cmd #147

Closed
bargar opened this issue Aug 23, 2016 · 5 comments
Closed

Option to allow row selection without ctrl/cmd #147

bargar opened this issue Aug 23, 2016 · 5 comments

Comments

@bargar
Copy link
Contributor

bargar commented Aug 23, 2016

Though I understand the logic behind the ctrl-click to toggle individual rows, this may not be intuitive to users in some scenarios. Gmail is one of many examples where no meta keys are required to select/deselect individual rows.

I've added a configuration option to permit this behavior on a fork at /bargar/ember-light-table.

The existing behavior of course remains the default, but this tweak enables overriding it by setting lt-body property multiSelectRequiresKeyboard to false. Note: the shift click to select several consecutive rows behavior is unchanged in any event.

If there is interest and amenability, I would be happy to add testing and make a proper PR here in /offirgolan/ember-light-table.

@offirgolan
Copy link
Collaborator

@bargar a PR with this is very much welcomed 😸

@bargar
Copy link
Contributor Author

bargar commented Sep 3, 2016

@offirgolan #160 submitted, now including testing. Sorry for the delay!

@offirgolan
Copy link
Collaborator

Thanks again for you contribution @bargar! I should release this sometime this week 😸

@bargar
Copy link
Contributor Author

bargar commented Sep 7, 2016

My pleasure! Looking forward to it 🐸

@offirgolan
Copy link
Collaborator

@bargar this has been released in v1.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants