Customizable sort icon component

[RedTn]

It would be nice if there were some properties we can pass into the content of this element here:
https://github.com/offirgolan/ember-light-table/blob/master/addon/templates/components/columns/base.hbs#L6
Materialize expects the element to be defined like this:
<i class="material-icons">add</i>
http://materializecss.com/icons.html

[alexander-alvarez]

Should be able to accomplish this leveraging
http://offirgolan.github.io/ember-light-table/docs/classes/t.head.html#property_iconAscending
http://offirgolan.github.io/ember-light-table/docs/classes/t.head.html#property_iconDescending
and
http://offirgolan.github.io/ember-light-table/docs/classes/t.head.html#property_iconSortable

see the examples in the example app:

[RedTn]

Right, but materialize also requires the content in that i tag in order to determine the icon to use.
So in my example, it requires:
<i ...>add</i>.
Ideally, we could do something like:
{{t.head ... iconSortable="material-icons" iconSortableValue="add"}}

[alexander-alvarez]

got it, now I understand.. I've never heard of anything like that, but I understand how it works.

In the meantime you can define your own column component that gets called here.
You can generate it with ember g column-type <your_column_type>
and set the http://offirgolan.github.io/ember-light-table/docs/classes/Column.html#property_type property on your columns passed into to light table.

I'm not sure if we would want to yet another property for icons or maybe make the icon component customizable all together.

@buschtoens any thoughts?

[buschtoens]

I've never heard of anything like that, but I understand how it works.

Count me in. 😄

I'm not sure if we would want to yet another property for icons or maybe make the icon component customizable all together.

I'm on the same page. We should rather add an iconComponet to the TableHeaderMixin and render it instead of the <i> tag, that was already getting a bit too complex anyways.

Absolutely in favor! 👍

[RedTn]

PR Created: #489