-
-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implicit creation of rows when new data added to model? #52
Comments
@schickm I just use the |
Gotcha, but I was thinking of a scenario where my component receives a RecordArray as the model. At some point in the future records are added/removed from the RecordArray due to changes in the store. This would mean that Hopefully I'm making sense here... If there was a way to demonstrate this using an ember twiddle I'd love to...but looks like the ember twiddle folks are still working on addon support I guess I could use one of those dreaded observers that everyone tells me not to use... Thanks for getting back to me! |
@schickm are you sure it wouldn't fire? You may be right, since our model is slightly different, and is a model with an array as just one property inside it, but when we load more records into the store, and they are pulled into that array, the |
@schickm as of right now, implicit row creation is not on the backlog. Maybe in the future but the current goal of this addon is to focus mostly on the table component rendering and give you all the power on when and how rows/columns are added/removed/modified. Ill leave this open for now so that way I wont forget! |
@offirgolan makes sense, I got that feeling from looking at the API. If/when I get a good non-observer based approach to this, I'll post it here for others interested. |
@schickm I create a PR #79 that adds a |
Done! (#167) 😸 |
I've noticed that you have to manually call
table.addRow()
if you'd like a new row to appear in the table. Is it possible to have the table watch the initial passed in model to the constructor for changes? Or is adding rows at runtime not really a priority feature for this table addon?The text was updated successfully, but these errors were encountered: