Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated Implicit Injections #277

Closed
nbibler opened this issue Mar 31, 2021 · 1 comment · Fixed by #279
Closed

Deprecated Implicit Injections #277

nbibler opened this issue Mar 31, 2021 · 1 comment · Fixed by #279

Comments

@nbibler
Copy link

nbibler commented Mar 31, 2021

ember-metrics appears to cause a new deprecation warning in Ember 3.26 applications:

DEPRECATION: A value was injected implicitly on the 'options' property of an instance of <app@service:metrics::ember123>. Implicit injection is now deprecated, please add an explicit injection for this value. If the injected value is a service, consider using the @service decorator. [deprecation id: implicit-injections] See https://deprecations.emberjs.com/v3.x#toc_implicit-injections for more details.
@cah-brian-gantzler cah-brian-gantzler mentioned this issue May 6, 2021
Merged
@nbibler
Copy link
Author

nbibler commented Jun 21, 2021

Thank you @cah-briangantzler and @jherdman!

@cah-brian-gantzler cah-brian-gantzler mentioned this issue Sep 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed initializer. Create options in server init bgantzler/ember-metrics
1 participant
@nbibler