Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is-active does not get recomputed when currentRouteName changes #4

Closed
juggy opened this issue Jul 17, 2017 · 0 comments · Fixed by #263
Closed

is-active does not get recomputed when currentRouteName changes #4

juggy opened this issue Jul 17, 2017 · 0 comments · Fixed by #263

Comments

@juggy
Copy link

juggy commented Jul 17, 2017

Hello,

is-active should recompute when router.currentRouteName changes:

currentRouteRefreshed: Ember.observer("router.currentRouteName", function(){
    this.recompute();
  }),

Might need some fine tuning as it seems it can call recompute more than once within a single transition and it gives a "rendered twice in a run loop" error.

(I tried to create a test for it, but I can't seem to get them to work properly with the transition)

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant