Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated test targets in jcstress #4232

Closed
llxia opened this issue Jan 10, 2023 · 3 comments · Fixed by #4266
Closed

Duplicated test targets in jcstress #4232

llxia opened this issue Jan 10, 2023 · 3 comments · Fixed by #4266

Comments

@llxia
Copy link
Contributor

llxia commented Jan 10, 2023

Describe the bug
Noticed duplicated test targets in jcstress

00:18:08.402  autoGen.mk:2376: warning: overriding recipe for target 'jcstress_LongAtomicityTest_0'
00:18:08.402  autoGen.mk:1984: warning: ignoring old recipe for target 'jcstress_LongAtomicityTest_0'
00:18:08.402  autoGen.mk:2404: warning: overriding recipe for target 'jcstress_VolatileFloatAtomicityTest_0'
00:18:08.402  autoGen.mk:2012: warning: ignoring old recipe for target 'jcstress_VolatileFloatAtomicityTest_0'
00:18:08.402  autoGen.mk:2432: warning: overriding recipe for target 'jcstress_FloatAtomicityTest_0'
00:18:08.402  autoGen.mk:2040: warning: ignoring old recipe for target 'jcstress_FloatAtomicityTest_0'
00:18:08.402  autoGen.mk:2460: warning: overriding recipe for target 'jcstress_ByteAtomicityTest_0'
00:18:08.403  autoGen.mk:2068: warning: ignoring old recipe for target 'jcstress_ByteAtomicityTest_0'
00:18:08.403  autoGen.mk:2488: warning: overriding recipe for target 'jcstress_CharAtomicityTest_0'
00:18:08.403  autoGen.mk:2096: warning: ignoring old recipe for target 'jcstress_CharAtomicityTest_0'
00:18:08.403  autoGen.mk:2516: warning: overriding recipe for target 'jcstress_VolatileDoubleAtomicityTest_0'
00:18:08.403  autoGen.mk:2124: warning: ignoring old recipe for target 'jcstress_VolatileDoubleAtomicityTest_0'
00:18:08.403  autoGen.mk:2544: warning: overriding recipe for target 'jcstress_DoubleAtomicityTest_0'
00:18:08.403  autoGen.mk:2152: warning: ignoring old recipe for target 'jcstress_DoubleAtomicityTest_0'
00:18:08.403  autoGen.mk:2572: warning: overriding recipe for target 'jcstress_IntAtomicityTest_0'
00:18:08.403  autoGen.mk:2180: warning: ignoring old recipe for target 'jcstress_IntAtomicityTest_0'
00:18:08.403  autoGen.mk:2600: warning: overriding recipe for target 'jcstress_ShortAtomicityTest_0'
00:18:08.403  autoGen.mk:2208: warning: ignoring old recipe for target 'jcstress_ShortAtomicityTest_0'
00:18:08.403  autoGen.mk:2628: warning: overriding recipe for target 'jcstress_VolatileByteAtomicityTest_0'
00:18:08.403  autoGen.mk:2236: warning: ignoring old recipe for target 'jcstress_VolatileByteAtomicityTest_0'
00:18:08.403  autoGen.mk:2656: warning: overriding recipe for target 'jcstress_VolatileIntAtomicityTest_0'
00:18:08.403  autoGen.mk:2264: warning: ignoring old recipe for target 'jcstress_VolatileIntAtomicityTest_0'
00:18:08.403  autoGen.mk:2684: warning: overriding recipe for target 'jcstress_VolatileLongAtomicityTest_0'
00:18:08.403  autoGen.mk:2292: warning: ignoring old recipe for target 'jcstress_VolatileLongAtomicityTest_0'
00:18:08.403  autoGen.mk:2712: warning: overriding recipe for target 'jcstress_VolatileShortAtomicityTest_0'
00:18:08.403  autoGen.mk:2320: warning: ignoring old recipe for target 'jcstress_VolatileShortAtomicityTest_0'
00:18:08.403  autoGen.mk:2740: warning: overriding recipe for target 'jcstress_VolatileCharAtomicityTest_0'
00:18:08.403  autoGen.mk:2348: warning: ignoring old recipe for target 'jcstress_VolatileCharAtomicityTest_0'
00:18:08.403  autoGen.mk:4448: warning: overriding recipe for target 'jcstress_BoundedSingleTest_0'
00:18:08.403  autoGen.mk:4280: warning: ignoring old recipe for target 'jcstress_BoundedSingleTest_0'
00:18:08.403  autoGen.mk:4532: warning: overriding recipe for target 'jcstress_UnboundedSingleTest_0'
00:18:08.403  autoGen.mk:4308: warning: ignoring old recipe for target 'jcstress_UnboundedSingleTest_0'

https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_dev.system_x86-32_windows/6/consoleFull

We should remove the duplicate test targets in playlist
https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml

@llxia
Copy link
Contributor Author

llxia commented Jan 10, 2023

For example, search jcstress_LongAtomicityTest in jcstress/playlist.xml, it should have 2 matches and remove one of them.

<test>
<testCaseName>jcstress_LongAtomicityTest</testCaseName>
<command>$(JAVA_COMMAND) $(JVM_OPTIONS) -jar $(Q)$(LIB_DIR)$(D)jcstress-tests-all-20220908.jar$(Q) $(APPLICATION_OPTIONS) -t LongAtomicityTest; \
$(TEST_STATUS)</command>
<levels>
<level>dev</level>
</levels>
<groups>
<group>system</group>
</groups>
</test>

@ArkaprabhaChakraborty
Copy link
Contributor

Hi! Can I work on this issue?

@smlambert
Copy link
Contributor

Please do @ArkaprabhaChakraborty, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants